Fix various mmRest issues and some refactoring of anchor-related functions #29887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Small thing regarding MM rest fretboard diagrams delete leave two chord symbols video1175805295.mp4Not a showstopper, can be fixed separately |
@zacjansheski thanks! Fixed in the last commit. |
This was the cause of musescore#29897
Reject segment move on drag if destination segment is on MMRest
|
Update: fixed #29897 too. @zacjansheski please give this another try and also check for regressions of #29690 |
its-not-nice
approved these changes
Sep 16, 2025
4 tasks
|
Also fixes #29898 |
miiizen
approved these changes
Sep 17, 2025
mike-spa
added a commit
to mike-spa/MuseScore
that referenced
this pull request
Sep 17, 2025
Fix various mmRest issues and some refactoring of anchor-related functions
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #29114
Resolves: #29808
Resolves: #29813
All three issue have the same root cause, i.e. the fact that when creating MMRest we transfer the elements from the original measure onto the covering MMRest by link-cloning them. That's a very bad idea because it results in lots of copies of the elements that are very complicated to manage. This PR should hopefully put a temporary fix to that, but my plan is to get rid of that logic entirely in the near future.
I've additionally made small improvements and reorganizations of the anchor-related code. Needs be thoroughly checked for regressions on all the anchor-style-interactions (shift+arrow, dragging, etc).
UPDATE
Resolves: #29897 too
Resolves: #29893 too probably
Resolves: #29898
That regression was caused by #29804 so I've now partially reverted it and made a different solution for that issue.