Skip to content

Conversation

@thewh1teagle
Copy link

What does this PR do?

Add option to pass custom espeak-ng-data folder built from source for custom phonemes rules
by setting ESPEAK_DATA_PATH to the path of espeak-ng-data folder

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

It was fun!

@mush42
Copy link
Owner

mush42 commented Sep 10, 2024

@thewh1teagle good job!
The only needed change is in the optispeech package. For ospeech we copy these files from optispeech package when building the package.

@thewh1teagle
Copy link
Author

thewh1teagle commented Sep 11, 2024

The only needed change is in the optispeech package. For ospeech we copy these files from optispeech package when building the package.

It's useful to change in both for inferencing and testing when training
by the way it will be more efficient if there will be optispeech-common package instead of copy duplicate files

@mush42
Copy link
Owner

mush42 commented Sep 11, 2024

@thewh1teagle sounds good. For now let's limit the change to optispeech package, and I'll implement the common package next weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants