fetching master#1
Open
sakshi-arora1 wants to merge 467 commits into
Open
Conversation
…1594) * Added rule events and passed chanel information to child * Added rule events and passed chanel information to child * Removed unnecessary imports * Removed rule editor uber changes * mergedchanges and added missing one * mergedchanges and added missing one * Added test cases * modified null check
* Empty value fix * Empty value fix * Adding test cases * Fixing package info
Co-authored-by: Prateek Awasthi <[email protected]>
* FORMS-18801: State of active component lacks 3 to 1 contrast ratio @sunnym @vavarshn (#1632) Co-authored-by: Stefan Dragomir <[email protected]> * Fixing circle ci configuration (#1643) * feat: update token name and accesibility config (#1644) Co-authored-by: Prateek Awasthi <[email protected]> * FORMS-20749: Update af-core version to 0.22.143 (#1647) * Fixing adobe bot github token environment variable (#1646) * Support for fd:customDisplayFormat (#1619) * FORMS-18718: Desktop, RWD Tablet, RWD Mobile - Visual heading text is not marked as heading @sunnym @vavarshn (#1631) * FORMS-18633: Desktop, RWD Tablet, RWD Mobile - Visual heading text is not marked as heading @sunnym @vavarshn (#1630) * FORMS-20431: Update excludeFromDoRIfHidden prefix (#1617) * FORMS-20431: Update excludeFromDoRIfHidden prefix * FORMS-20431: Update test cases * FORMS-20431: Update the af-core version * FORMS-20431: Revert changes on package-lock.json --------- Co-authored-by: Rishi Mehta <[email protected]> * Forms-20262: FileInput v4 (#1618) * FORMS-20262: Handle invalid file attachments on client-side * add functionality to get collated alert message with multiple invalid errors * FORMS-20262: Update alert message content * FORMS-20262: Update alert message content * FORMS-20262: revert the fileinput base class to clean state * FORMS-20262: add size zero file error in error list * FORMS-20262: create fileinput v4 * checks for file size of 0 and throws error * collates all error messages in single alert * FORMS-20262: Update file input v4 readme * FORMS-20262: Update component version to v4 in readme * FORMS-20262: test cases for fileinput v4 * add collateral * create page for fileinput v4 * FORMS-20262: Update copyright year * FORMS-20262: fix resource super type * FORMS-20262: fix tracking feature for file input * FORMS-20262: add error message for zero-bytes file in all locale * FORMS-20262: mark head text as isHeading * FORMS-20262: pom replace fileinput v4 in libs * FORMS-19758: Addition of fragmentPath to the CRISPR JSON in Author View (#1593) * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * updating crispr spec version in dialog * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * RTC Updated AdaptiveFormVersion * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * RTC Updated AdaptiveFormVersion * RTC Updated AdaptiveFormVersion or rest-submission * RTC Updated AdaptiveFormVersion or rest-submission * RTC Updated AdaptiveFormVersion in formcontainerv2 * RTC Updated AdaptiveFormVersion in formcontainerv2WithAutoSave * Fixing code formatting --------- Co-authored-by: srivastv <[email protected]> Co-authored-by: Rishi Mehta <[email protected]> * feat(print-properties): Adding `dorContainer` in each component and `pageTemplate` in FormContainer and new print specific components (#1567) * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Adding channel check while resolving fragment * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Reformatting to avoid unnecessary changes * feat(print-properties): Removing unnecessary file * feat(print-properties): Removing unnecessary file * feat(print-properties): Refactoring changes * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Adding channel check while resolving fragment * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Reformatting to avoid unnecessary changes * feat(print-properties): Removing unnecessary file * feat(print-properties): Removing unnecessary file * feat(print-properties): Refactoring changes * feat(print-properties): Fixing issues with rebasing * feat(print-properties): Import sorting * feat(print-properties): Removing unnecessary file * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Adding channel check while resolving fragment * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Reformatting to avoid unnecessary changes * feat(print-properties): Removing unnecessary file * feat(print-properties): Removing unnecessary file * feat(print-properties): Refactoring changes * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Adding channel check while resolving fragment * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Reformatting to avoid unnecessary changes * feat(print-properties): Removing unnecessary file * feat(print-properties): Removing unnecessary file * feat(print-properties): Refactoring changes * feat(print-properties): Fixing issues with rebasing * feat(print-properties): Import sorting * feat(print-properties): Removing unnecessary file * feat(print-properties): Removing synthetic resource changes * feat(print-properties): Adding test case for channel based fragment resolution * feat(print-properties): Removing the pageTemplate handling as it is not in separate PrintContainer * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Adding channel check while resolving fragment * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Reformatting to avoid unnecessary changes * feat(print-properties): Removing unnecessary file * feat(print-properties): Removing unnecessary file * feat(print-properties): Refactoring changes * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Adding channel check while resolving fragment * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Reformatting to avoid unnecessary changes * feat(print-properties): Removing unnecessary file * feat(print-properties): Removing unnecessary file * feat(print-properties): Refactoring changes * feat(print-properties): Fixing issues with rebasing * feat(print-properties): Import sorting * feat(print-properties): Removing unnecessary file * feat(print-properties): Adding the change to resolve fragment based on its guideContainer in hierarchy * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Adding channel check while resolving fragment * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Reformatting to avoid unnecessary changes * feat(print-properties): Removing unnecessary file * feat(print-properties): Removing unnecessary file * feat(print-properties): Refactoring changes * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Adding channel check while resolving fragment * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Reformatting to avoid unnecessary changes * feat(print-properties): Removing unnecessary file * feat(print-properties): Removing unnecessary file * feat(print-properties): Refactoring changes * feat(print-properties): Fixing issues with rebasing * feat(print-properties): Import sorting * feat(print-properties): Removing unnecessary file * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Adding channel check while resolving fragment * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Reformatting to avoid unnecessary changes * feat(print-properties): Removing unnecessary file * feat(print-properties): Removing unnecessary file * feat(print-properties): Refactoring changes * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Adding channel check while resolving fragment * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Reformatting to avoid unnecessary changes * feat(print-properties): Removing unnecessary file * feat(print-properties): Removing unnecessary file * feat(print-properties): Refactoring changes * feat(print-properties): Fixing issues with rebasing * feat(print-properties): Import sorting * feat(print-properties): Removing unnecessary file * feat(print-properties): Removing synthetic resource changes * feat(print-properties): Adding test case for channel based fragment resolution * feat(print-properties): Removing the pageTemplate handling as it is not in separate PrintContainer * feat(print-properties): Removing code came due to merge conflicts * feat(print-properties): Removing new schema; it is used in print specific sdk * feat(print-properties): Removing new field types * feat(print-properties): Updating version of dor api package * feat(print-properties): Converting string literals to constants * feat(print-properties): Adding test case for getDorContainer in the FormComponent inetrface * feat(print-cc): Adding changes to pass down channel info to correctly resolve fragment * feat(print-cc): Removing unnecessary change * feat(print-cc): Adding dorcontainer check in UT * feat(print-cc): Fixing conflict issues * feat(print-cc): Fixing conflict issues * feat(print-cc): Adding test cases for Views classes * feat(print-cc): Adding test case * FORMS-19758: Addition of fragmentPath to the CRISPR JSON in Author View (#1593) * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * updating crispr spec version in dialog * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * RTC Updated AdaptiveFormVersion * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * RTC Updated AdaptiveFormVersion * RTC Updated AdaptiveFormVersion or rest-submission * RTC Updated AdaptiveFormVersion or rest-submission * RTC Updated AdaptiveFormVersion in formcontainerv2 * RTC Updated AdaptiveFormVersion in formcontainerv2WithAutoSave * Fixing code formatting --------- Co-authored-by: srivastv <[email protected]> Co-authored-by: Rishi Mehta <[email protected]> * feat(print-cc): Updating version in test case --------- Co-authored-by: dhrsharm <[email protected]> Co-authored-by: vjystva <[email protected]> Co-authored-by: srivastv <[email protected]> Co-authored-by: Rishi Mehta <[email protected]> * Adding scribble signature support. (#1651) * Adding scribble signature support. * Adding scribble signature support. * Adding scribble signature support. * Moving the test logic to then post click. * Moving the test logic to then post click. * Moving the test logic to then post click. * Moving the test logic to then post click. * Moving the test logic to then post click. * Addressing review comments. * Moving the test logic to then post click. * Addressing review comments. * Addressing review comments. * Moving the test logic to then post click. * Fixing enter keydown event on forms (#1653) * link fix * Link fix * Fixing issue * FORMS-19721 Addition of rules to the CRISPR JSON for print channel (#1594) * Added rule events and passed chanel information to child * Added rule events and passed chanel information to child * Removed unnecessary imports * Removed rule editor uber changes * mergedchanges and added missing one * mergedchanges and added missing one * Added test cases * modified null check * Empty value (#1654) * Empty value fix * Empty value fix * Adding test cases * Fixing package info * feat: token name updated (#1652) Co-authored-by: Prateek Awasthi <[email protected]> * Fixing token * Resolving merge conflicts --------- Co-authored-by: Stefan Dragomir <[email protected]> Co-authored-by: Stefan Dragomir <[email protected]> Co-authored-by: Prateek Awasthi <[email protected]> Co-authored-by: Prateek Awasthi <[email protected]> Co-authored-by: anshikag-adobe <[email protected]> Co-authored-by: Talmiz Ahmed <[email protected]> Co-authored-by: CezarSTF <[email protected]> Co-authored-by: vjystva <[email protected]> Co-authored-by: srivastv <[email protected]> Co-authored-by: DhruvSharma-845 <[email protected]> Co-authored-by: dhrsharm <[email protected]> Co-authored-by: sakshi-arora1 <[email protected]>
* date time input field * date time fixes * Added test cases * fixed default message issue * fixed formatting * fixing code coverage * removed css and fixed formatting * Incorporated review comments * Added cypress tests on authoring and runtime --------- Co-authored-by: dgurjar <[email protected]>
* Date time input field (#1587) * date time input field * date time fixes * Added test cases * fixed default message issue * fixed formatting * fixing code coverage * removed css and fixed formatting * Incorporated review comments * Added cypress tests on authoring and runtime --------- Co-authored-by: dgurjar <[email protected]> * @releng updating af-core (#1657) --------- Co-authored-by: Devendra Gurjar <[email protected]> Co-authored-by: dgurjar <[email protected]>
…es (#1662) * FORMS-21023: close datepicker on touch event in mobile/tablet devices * Added event listener for touch event outside the calendar widget * FORMS-21023: cypress tests for datepicker in mobile/tablet layout
DevToMaster 22-07
Dev master2403
…rties feat(dialog): expose fieldType and fd:viewType via hidden dialog fields
FORMS-21913 - Updating a11y options for switch custom text
FORMS-18050 - Adding logs for AF2 Submit API
…#1829) * placeholder option should be visible not the empty option when the dropdown is reset * modified the collateral for the test * modified test to check for placeholder on clearing with rule editor * clearing the selected attribute from all the options to avoid stale selection * code refactoring * code refactoring * code refactoring * updated tests * reselecting the placeholder option back on reset * should get the select attribute only when we have placeholder text * code refactoring * updated the tests * fixing the cypress tests * placeholder should have selected attribute on reseting the dropdown * fixed the comment --------- Co-authored-by: Armaan Gupta <[email protected]>
* feat(dialog): add fieldType hidden field to container v2 dialog Adds a hidden select field for fieldType with value 'form' to the container v2 dialog, consistent with all other AF2 component dialogs. This exposes the container's fieldType via the Content API's componentDefinitions endpoint, enabling type validation of patches targeting form container properties. Co-Authored-By: Claude Sonnet 4.6 <[email protected]> * chore(fileinput): describe accept field for definition API * chore(checkbox): clarify conditional unchecked value metadata * fix(text): omit default richText from export --------- Co-authored-by: Claude Sonnet 4.6 <[email protected]>
* focus on first invalid field for wizard * removed console log * test case added * only removed * review comments incorporated --------- Co-authored-by: Rajat Khurana <[email protected]>
* wizard js processing fixed * test cases fixed --------- Co-authored-by: Rajat Khurana <[email protected]>
… team (#1832) Co-authored-by: Armaan Gupta <[email protected]>
Documents the six most common defect classes found in new component PRs: - Required artifacts table (ui.af.apps, IT content, Cypress spec, exporter JSONs) - ReservedProperties double-emission trap and how to avoid it - getFieldType() contract (must delegate to super) - Orientation enum reuse (CheckBox.Orientation) - ContainerConstraint pattern for option fields - Required test patterns (testJSONExport, getProperties guard) Knowledge derived from reviewing ImageChoice component (PR #1847). Co-authored-by: Claude Sonnet 4.6 <[email protected]>
* Adding Image Choice component. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> * Adding scribble OOTB, and hiding imageChoice OOTB. * ImageChoice: address PR review feedback - Reuse CheckBox.Orientation instead of duplicating the enum - Register PN_SELECTION_TYPE in ReservedProperties so it no longer double-emits at top level (it only belongs under afs:layout) - Delegate getFieldType() to super.getFieldType(default) so JCR fieldType is honored - Make enum value field final; drop dead null guards on orientation and selectionType (their fromString never returns null) - Add testJSONExport + exporter-imagechoice.json golden fixture, and assert selectionType does not leak to the top-level properties - @JsonIgnore getImageSrc() and emit imageSrc under afs:layout to satisfy the AF2 schema (imageSrc is not a top-level property); runtime imagechoiceview.js updated to read from properties.afs:layout * ImageChoice: address PR review feedback (round 2) - Rebuild #createOption imperatively (createElement / setAttribute / textContent) instead of concatenating model data into a string set via innerHTML — closes XSS on enum values and labels - updateEnumNames empty-widget fallback now passes the enum VALUE as the input value and the enum NAME as the label (was passing the display name as the submit value — silent data corruption when value != name) - widget.html data-sly-test now uses imageSrc[itemList.index] so the image span is skipped for rows where no imageSrc is provided (previously any imageSrc entry gated the whole list, so short arrays rendered src="null") - Dialog imageSrc pathfield filter changed from "hierarchyNotFile" (folder-only) to "file" so authors can actually pick an image - Add golden exporter fixtures and tests for the customized, multi, and datalayer variants — the multi fixture is the only one that exercises fieldType: checkbox-group --------- Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>
* FORMS-24917: Allow print channel in author mode check * FORMS-24917: Reverted testPrintChannelRuleNotInPublish to testPrintChannelRule * FORMS-24917: Clarify Print Channel requirements in test Added a comment to clarify requirements for Print Channel. * Reverted change "Mock resource to return null for 'fd:rules' child"
* DoR generation for forms inside Site pages. * Adding condition in case DoR tab is not visible based on FT. * Address PR review feedback for DoR on Site pages - editDialog.js: guard foundationField with null-check in manageDeleteFields persist path to prevent NPE when field is not in DOM - editDialog.js: make manageFDViewPayload idempotent by removing existing fd:view/print hidden inputs before appending to avoid duplicate Sling POST values - editDialog.js: fix Sling POST type hint for dorTemplateChanged so it stores as Boolean instead of the literal string "Boolean" - dorhook.js: add trailing slash to /content/forms/af prefix check in openDorDialog and initPreviewDoR so paths like /content/forms/af-x don't match - container _cq_dialog/.content.xml: rename misspelled JCR node dorTiltle to dorTitle Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]> * Added fallback only when value is empty in dailog. --------- Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]>
* Updating a11y options for switch custom text * Adding switch authoring tests * Merge pull request #1841 from adobe/rismehta/feat-dialog-hidden-properties feat(dialog): expose fieldType and fd:viewType via hidden dialog fields * Adding logs for AF2 Submit API * [FORMS-24195] : Resetting a dropdown component with placeholder value (#1829) * placeholder option should be visible not the empty option when the dropdown is reset * modified the collateral for the test * modified test to check for placeholder on clearing with rule editor * clearing the selected attribute from all the options to avoid stale selection * code refactoring * code refactoring * code refactoring * updated tests * reselecting the placeholder option back on reset * should get the select attribute only when we have placeholder text * code refactoring * updated the tests * fixing the cypress tests * placeholder should have selected attribute on reseting the dropdown * fixed the comment --------- Co-authored-by: Armaan Gupta <[email protected]> * feat(dialog): add fieldType hidden field to container v2 dialog (#1843) * feat(dialog): add fieldType hidden field to container v2 dialog Adds a hidden select field for fieldType with value 'form' to the container v2 dialog, consistent with all other AF2 component dialogs. This exposes the container's fieldType via the Content API's componentDefinitions endpoint, enabling type validation of patches targeting form container properties. Co-Authored-By: Claude Sonnet 4.6 <[email protected]> * chore(fileinput): describe accept field for definition API * chore(checkbox): clarify conditional unchecked value metadata * fix(text): omit default richText from export --------- Co-authored-by: Claude Sonnet 4.6 <[email protected]> * Forms 24186 invalid field focus wizard (#1857) * focus on first invalid field for wizard * removed console log * test case added * only removed * review comments incorporated --------- Co-authored-by: Rajat Khurana <[email protected]> * Wizard Fix for child addition (#1856) * wizard js processing fixed * test cases fixed --------- Co-authored-by: Rajat Khurana <[email protected]> * FORMS-24176 : Changed label and tooltip provided by the documentation team (#1832) Co-authored-by: Armaan Gupta <[email protected]> * docs(architecture): add new component checklist to overview (#1863) Documents the six most common defect classes found in new component PRs: - Required artifacts table (ui.af.apps, IT content, Cypress spec, exporter JSONs) - ReservedProperties double-emission trap and how to avoid it - getFieldType() contract (must delegate to super) - Orientation enum reuse (CheckBox.Orientation) - ContainerConstraint pattern for option fields - Required test patterns (testJSONExport, getProperties guard) Knowledge derived from reviewing ImageChoice component (PR #1847). Co-authored-by: Claude Sonnet 4.6 <[email protected]> * Adding Image Choice component. (#1847) * Adding Image Choice component. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> * Adding scribble OOTB, and hiding imageChoice OOTB. * ImageChoice: address PR review feedback - Reuse CheckBox.Orientation instead of duplicating the enum - Register PN_SELECTION_TYPE in ReservedProperties so it no longer double-emits at top level (it only belongs under afs:layout) - Delegate getFieldType() to super.getFieldType(default) so JCR fieldType is honored - Make enum value field final; drop dead null guards on orientation and selectionType (their fromString never returns null) - Add testJSONExport + exporter-imagechoice.json golden fixture, and assert selectionType does not leak to the top-level properties - @JsonIgnore getImageSrc() and emit imageSrc under afs:layout to satisfy the AF2 schema (imageSrc is not a top-level property); runtime imagechoiceview.js updated to read from properties.afs:layout * ImageChoice: address PR review feedback (round 2) - Rebuild #createOption imperatively (createElement / setAttribute / textContent) instead of concatenating model data into a string set via innerHTML — closes XSS on enum values and labels - updateEnumNames empty-widget fallback now passes the enum VALUE as the input value and the enum NAME as the label (was passing the display name as the submit value — silent data corruption when value != name) - widget.html data-sly-test now uses imageSrc[itemList.index] so the image span is skipped for rows where no imageSrc is provided (previously any imageSrc entry gated the whole list, so short arrays rendered src="null") - Dialog imageSrc pathfield filter changed from "hierarchyNotFile" (folder-only) to "file" so authors can actually pick an image - Add golden exporter fixtures and tests for the customized, multi, and datalayer variants — the multi fixture is the only one that exercises fieldType: checkbox-group --------- Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]> * FORMS-24917: Fixed isAuthorMode Null Request Issue in IC (#1865) * FORMS-24917: Allow print channel in author mode check * FORMS-24917: Reverted testPrintChannelRuleNotInPublish to testPrintChannelRule * FORMS-24917: Clarify Print Channel requirements in test Added a comment to clarify requirements for Print Channel. * Reverted change "Mock resource to return null for 'fd:rules' child" * DoR generation for forms inside Site pages. (#1862) * DoR generation for forms inside Site pages. * Adding condition in case DoR tab is not visible based on FT. * Address PR review feedback for DoR on Site pages - editDialog.js: guard foundationField with null-check in manageDeleteFields persist path to prevent NPE when field is not in DOM - editDialog.js: make manageFDViewPayload idempotent by removing existing fd:view/print hidden inputs before appending to avoid duplicate Sling POST values - editDialog.js: fix Sling POST type hint for dorTemplateChanged so it stores as Boolean instead of the literal string "Boolean" - dorhook.js: add trailing slash to /content/forms/af prefix check in openDorDialog and initPreviewDoR so paths like /content/forms/af-x don't match - container _cq_dialog/.content.xml: rename misspelled JCR node dorTiltle to dorTitle Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]> * Added fallback only when value is empty in dailog. --------- Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]> --------- Co-authored-by: Muskan Gupta <[email protected]> Co-authored-by: muskgupta <[email protected]> Co-authored-by: sakshi-arora1 <[email protected]> Co-authored-by: Armaan Gupta <[email protected]> Co-authored-by: Armaan Gupta <[email protected]> Co-authored-by: Claude Sonnet 4.6 <[email protected]> Co-authored-by: Rajat Khurana <[email protected]> Co-authored-by: Rajat Khurana <[email protected]> Co-authored-by: Shivangi Mittal <[email protected]>
FORMS-24887 Add support to exclude attachments for DoR (#1868)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: