Skip to content

Keep origin status bar style if possible #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Keep origin status bar style if possible #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a58b08
Keep the presenting view controller status bar style if possible.
yageek Feb 14, 2014
47a1ae5
Keep presenting view controller style if possible
yageek Feb 14, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Source/MMProgressHUDViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,12 +113,16 @@ - (void)dealloc {
MMHudLog(@"dealloc");
}

- (UIStatusBarStyle)preferredStatusBarStyle{
- (UIStatusBarStyle)preferredStatusBarStyle
{
if([self.presentingViewController respondsToSelector:@selector(preferredStatusBarStyle)]){
Copy link
Contributor

@larsacus larsacus Feb 17, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is presentingViewController non-nil for the only view controller in a window?

Copy link
Author

@yageek yageek Feb 17, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If presentingViewControlleris nil, a message is sent to nil and the test fails
if([self.presentingViewController respondsToSelector:@selector(preferredStatusBarStyle)]) equals if(nil) and the code below will not be called.

Copy link
Contributor

@larsacus larsacus Feb 17, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the above is true, I was asking because I'm not positive that presentingViewController is ever non-nil. Since this view controller is never really ever presented, and simply used as the root view controller of a window that we control. The only way I could see this working is if the presentedViewController that we are querying is on the key window's root view controller and not our own window.

Copy link
Author

@yageek yageek Feb 19, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I did tests with a tab bar controller based application and a navigation controller based application and the behavior is different. With the tab bar based application, the presentingViewController is the controller within the tab bar that presented the HUD. With the navigation controller, presentingViewController is nil.

return [self.presentingViewController preferredStatusBarStyle];
}

return [[UIApplication sharedApplication] statusBarStyle];
}

- (BOOL)prefersStatusBarHidden{
return [[UIApplication sharedApplication] isStatusBarHidden];
}

@end