fix: refrain from sending error dimensions on non-error events #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daytime-em
approved these changes
Jun 17, 2024
Base automatically changed from
ajlb/feat/non-fatal-error-API
to
releases/v4.0.0
June 17, 2024 20:51
andrewjl-mux
force-pushed
the
ajlb/fix/update-error-handling
branch
2 times, most recently
from
2661b40 to
323e3d9
Compare
additionally, separate check for player paused
andrewjl-mux
force-pushed
the
ajlb/fix/update-error-handling
branch
from
323e3d9 to
87d31be
Compare
Merged
andrewjl-mux
added a commit
that referenced
this pull request
Jun 18, 2024
* feat: expose error categorization dimensions (#242) * build: update minimum deployment target to iOS 12 * feat: expose error categorization parameters for error dispatch on bindings * docs: fixups * build: update package dependency * fix: refrain from sending error dimensions on non-error events (#243) * chore: remove deprecated API (#244) * chore: remove duplicate example (#245)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additionally, separate check for player paused