-
-
Notifications
You must be signed in to change notification settings - Fork 600
Signed parts #747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signed parts #747
Conversation
The test failures are the same as on master branch. This is sort of proof of concept and no extra tests are added. If you find this patch helpful, I will finish up the tests as well. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #747 +/- ##
==========================================
+ Coverage 89.43% 89.49% +0.06%
==========================================
Files 65 65
Lines 4845 4873 +28
Branches 850 862 +12
==========================================
+ Hits 4333 4361 +28
Misses 331 331
Partials 181 181
|
891b6e6
to
e303893
Compare
Tests are fixed. If you find this patch useful, I will add tests to cover the new changes. |
e303893
to
5e66ccc
Compare
Finished up tests. Please review :) |
Closing this in favor of #1428 which is based on the current master. |
Parse WSDL for
SignedParts
and use this knowneldge for signing.Close #497