Repository navigation
Migrate Calcit callbacks and validate canonical frontend CDN builds #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
1875936
ci: prevent retired Calcit snapshots from returning
tiye 9c3013a
fix: migrate input callbacks and validate frontend CDN builds
tiye 77d338b
Rely on COS Action verify instead of extra CDN tests
tiye a4665fc
Address CDN review comments and verify built assets
tiye File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
|
|
||
| .compact-inc.cirru | ||
| .calcit-error.cirru | ||
| compact.cirru | ||
| package.cirru | ||
|
|
||
| js-out/ | ||
| node_modules/ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,7 @@ | ||
|
|
||
| {} (:calcit-version |0.27.0) | ||
| :version |0.0.15-alpha.1 | ||
| :dependencies $ {} (|Respo/reel.calcit |0.6.33-alpha.1) | ||
| |Respo/respo-markdown.calcit |0.4.46-alpha.1 | ||
| |Respo/respo-ui.calcit |0.7.32-alpha.2 | ||
| :dependencies $ {} (|Respo/reel.calcit |0.6.33-alpha.2) | ||
| |Respo/respo-ui.calcit |0.7.32-alpha.3 | ||
| |Respo/respo.calcit |0.16.114-alpha.5 | ||
| |calcit-lang/js-ffi |0.2.1-alpha.10 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import assert from "node:assert/strict"; | ||
| import { existsSync, readFileSync } from "node:fs"; | ||
| import { test } from "node:test"; | ||
|
|
||
| const dist = new URL("../dist/", import.meta.url); | ||
|
|
||
| test("built HTML loads its generated assets from the selected CDN path", () => { | ||
| const base = process.env.VITE_BASE_URL; | ||
| assert.ok(base?.startsWith("https://"), "build with VITE_BASE_URL before testing"); | ||
| const html = readFileSync(new URL("index.html", dist), "utf8"); | ||
| const urls = [...html.matchAll(/(?:src|href)="([^"]+)"/g)] | ||
| .map((match) => match[1]) | ||
| .filter((url) => url.includes("assets/")); | ||
| assert.ok(urls.some((url) => url.endsWith(".js")), "built HTML must reference generated JavaScript"); | ||
| for (const url of urls) { | ||
| assert.ok(url.startsWith(`${base}assets/`), `${url} must use ${base}`); | ||
| assert.ok(existsSync(new URL(url.slice(base.length), dist)), `${url} must exist in dist`); | ||
| } | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| import { defineConfig } from 'vite'; | ||
|
|
||
| export default defineConfig({ base: process.env.VITE_BASE_URL || './' }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.