Updates Cats90 and all other PX1 specific classes #1088
Conversation
There was a problem hiding this comment.
Why defining PX1Resolution and not just use the resolution HO instead. You only need to configure the xml file.
Also could you explain why defining extra PX1DetectorDistance, as it could be just a TangoMotor.
Since you are on it, we use google style doc strings to describe methods and classes documentation (please, see in the contributing guidelines for more details)
|
Hi @beteva I saw your posts after running the pre-commit pushing the files. I will remove that line from Cats90.py I missed that. You are right about the Resolution and TangoMotor. These are the actual classes that are used and configured in the beamline_config.yml file. Although I updated the PX1Resolution and PX1DetectorDistance these are not currently being used. |
|
The updates to the PX1DetectorDistance and PX1Resolution were made quite a long time ago and I decided to include them as well in this commit to update the file although they are not in use at the moment since we use the Resolution and TangoMotor classes as you pointed out. |
|
I can remove those files that are not in use if you think it is best. |
Co-authored-by: fabcor <[email protected]>
Co-authored-by: fabcor <[email protected]>
Co-authored-by: fabcor <[email protected]>
|
@hellmig could you, please, check if the changes made in Cats90.py are OK for you. Thanks |
No description provided.