Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic tests #39

Merged
merged 5 commits into from
May 2, 2023
Merged

Add basic tests #39

merged 5 commits into from
May 2, 2023

Conversation

mxdvl
Copy link
Owner

@mxdvl mxdvl commented Apr 26, 2023 •
edited
Loading

  • tests: end-to-end build & dev
  • test: run in CI

Related to #35

@mxdvl mxdvl requested a review from sndrs April 28, 2023 14:18
@mxdvl mxdvl changed the title Add tests Add basic tests Apr 28, 2023
@sndrs sndrs linked an issue Apr 28, 2023 that may be closed by this pull request
Tests #35
Open
6 tasks
sndrs
sndrs approved these changes Apr 28, 2023
View reviewed changes
Copy link
Collaborator

@sndrs sndrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

note that some flags are renamed in #40, (as well adding a js API)

@mxdvl mxdvl removed a link to an issue May 2, 2023
Tests #35
Open
6 tasks
@mxdvl mxdvl merged commit e120fb9 into main May 2, 2023
@mxdvl mxdvl deleted the tests branch May 2, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sndrs sndrs sndrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxdvl @sndrs