Refactor MPCD cell property calculation and communication #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mphoward
requested changes
Dec 17, 2025
Collaborator
mphoward
left a comment
mphoward
left a comment
There was a problem hiding this comment.
Thanks Michaela! This overall looks really good to me, nice work. I have some comments for things to have a look at and take care of. Let me know if you have any questions!
| @@ -1,8 +1,6 @@ | |||
| # external_field test will not link properly due to separable compilation, disabling. | |||
| set(TEST_LIST | |||
| at_collision_method | |||
Collaborator
There was a problem hiding this comment.
Documenting that this test needs to be added back later.
Co-authored-by: Michael Howard <[email protected]>
Co-authored-by: Michael Howard <[email protected]>
This reverts commit 5845318.
mphoward
reviewed
Jan 6, 2026
Collaborator
mphoward
left a comment
mphoward
left a comment
There was a problem hiding this comment.
This looks really good Michaela! Just a couple small comments. Let's discuss the next steps.
mphoward
reviewed
Jan 12, 2026
Collaborator
mphoward
left a comment
mphoward
left a comment
There was a problem hiding this comment.
I think you've addressed all comments give so far!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.