Repository navigation
Run the app services under an init so finished children get reaped - #179
Merged
Merged
Conversation
schedule:work and queue:work sit at PID 1 in their containers and never wait() for children that were reparented to them; each scheduler tick leaves one zombie, and on a host where the container user maps to a real account those zombies count against its process limit until nothing under that user can fork. init: true on the shared anchor puts docker-init in front of all three services. ProductionComposeHealthcheckTest guards it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012bBptf9B3BtyeQaTWMrosd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
init: trueon the sharedx-appanchor incompose.production.yaml, so app, queue, and scheduler get docker-init as PID 1.schedule:workandqueue:workare not inits: children that finish get reparented to them and are never reaped. Each scheduler tick leaves one zombie, and on a host where the container user maps to a real account those count against its process limit until nothing under that user can fork.ProductionComposeHealthcheckTestnow asserts the anchor carriesinit: true.Verification
docker compose -f compose.production.yaml configshowsinit: trueresolved onapp,queue, andscheduler.sail artisan test --filter=ProductionComposeHealthcheck: 3 passed.Compose-only change: rolling it out is
up -dwith the updated file; no image change.🤖 Generated with Claude Code
https://claude.ai/code/session_012bBptf9B3BtyeQaTWMrosd