fix: Test failing for toDate from string extension test (no-changelog)

[valya]

No description provided.

[netroy]

How about we create a general utility function like this, that can be also used in the app (if needed):

const getLocalISOString = (date: Date) => {
	const offset = date.getTimezoneOffset();
	const offsetAbs = Math.abs(offset);
	const isoString = new Date(date.getTime() - offset * 60 * 1000).toISOString();
	const hours = String(Math.floor(offsetAbs / 60)).padStart(2, '0');
	const minutes = String(offsetAbs % 60).padStart(2, '0');
	return `${isoString.slice(0, -1)}${offset > 0 ? '-' : '+'}${hours}:${minutes}`;
};

Then this test could be written as

test('.toDate() should work on a string', () => {
	const date = new Date(2022, 0, 3);
	expect(evaluate(`={{ "${getLocalISOString(date)}".toDate() }}`)).toEqual(date);
});

[valya]

Happy to do that. Any idea where it'd live? If not, I'll just throw it in the test utils for workflow.

[netroy]

Happy to do that. Any idea where it'd live? If not, I'll just throw it in the test utils for workflow.

For now packages/workflow/test/ExpressionExtensions/Helpers.ts could be a good place to put this in. We can move it elsewhere when we need to.

[netroy]

Thanks 👍🏽

[janober]

Got released with [email protected]