Refactored code base to rename to REST and organize better#132
Closed
Refactored code base to rename to REST and organize better#132
Conversation
Contributor
jlouvel
commented
Mar 12, 2026
jlouvel
commented
- renamed API server adapter to REST
- moved protocol specific classes to dedicated subpackages (e.g. io.naftiko.exposed.mcp)
- renamed API server adapter to REST - moved protocol specific classes to dedicated subpackages (e.g. io.naftiko.exposed.mcp)
Contributor
Author
|
The "test-tutorial" is failing, apparently due to usage of a previous Docker image that still expects the "api" adapter type versus the "rest" adapter type, while the YAML file now expects "rest" in this PR. Is this something expected? |
Contributor
|
@jlouvel we will change the test to be based on the actual code and not a outdated docker image. Likely by using jar rather than building a new Image each time ! |
Contributor
Author
|
I'll recreate a new PR for this once the other pending one #124 is merged. This will streamline the rebasing / refactoring process. I have the copilot instructions ready :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.