Skip to content

Conversation

@grarco
Copy link

@grarco grarco commented May 16, 2025

Modifies the code for the phase 3 proposal to write an extra key, the ibc trace one, to allow external tools to discover new ibc assets before they have been transferred.

@grarco grarco requested review from brentstone and yito88 May 16, 2025 13:01
@brentstone
Copy link
Contributor

Q: in the future when default rate limits are raised, we would need to manually add these trace keys for indexers to pick them up, right?

I'm almost wondering if the existing solution we have might just be best... @grarco?

@grarco
Copy link
Author

grarco commented May 19, 2025

Q: in the future when default rate limits are raised, we would need to manually add these trace keys for indexers to pick them up, right?

I'm almost wondering if the existing solution we have might just be best... @grarco?

The current solution we have in the indexer is the only one feasible I think. This PR just anticipates the writing of the trace key from the first transaction to the governance proposal that whitelists a new assets so that the indexer can pick it up immediately. In case we raised the default limits than I see no way to automate the indexer's discovery logic and we'll probably need to manually inject that into the DB (at least for some assets): alternatively, for assets that don't need a custom limit we can just wait for the first transaction to happen (if we didn't set custom limits these assets are probably not very relevant anyway). We can also close this PR if we think that manually updating the indexer's db is a better alternative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants