Skip to content

remove eth bridge and light sdk #4943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tzemanovic wants to merge 30 commits into
base: main
Choose a base branch
from
Open

remove eth bridge and light sdk #4943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
a718dc8
node: upgrade tendermint to 0.38
tzemanovic Apr 17, 2025
fe695e0
script: upgrade cometbft to 0.38.17
tzemanovic Apr 17, 2025
26af515
node: check that finalize_block returns results for req txs
tzemanovic Apr 22, 2025
53cb70d
node: move snapshot logic out from shim into shell
tzemanovic Apr 23, 2025
63d773b
node: refactor out AbcippShim
tzemanovic Apr 24, 2025
0a52846
node: refactor out abcipp shim types
tzemanovic Apr 28, 2025
1f02ba6
shell/abci: use u64 for block height
tzemanovic Apr 28, 2025
9877f65
changelog: add #4618
tzemanovic Apr 28, 2025
9654abc
ci: switch to image with updated cometBFT 0.38.17 version
tzemanovic Apr 29, 2025
d92a5a4
add pre-commit merkle tree to use in ABCI::FinalizeBlock
tzemanovic Sep 18, 2025
ab803c0
update comet client compact mode to 0.38
tzemanovic Oct 6, 2025
eb3d583
Updates usage of `end_block_events` to `finalize_block_events`
grarco Oct 8, 2025
3b4d65d
node/finalzie_block: fix missing results for failed txs
tzemanovic Oct 8, 2025
b602fb4
CI: update updated hermes
tzemanovic Oct 11, 2025
2aa1a76
set prev merkle root in BlockHeader
yito88 Oct 20, 2025
c2d4d01
update hermes
tzemanovic Oct 20, 2025
e95d6c8
Revert "add pre-commit merkle tree to use in ABCI::FinalizeBlock"
tzemanovic Oct 20, 2025
c63d0b0
update merkle tree on ABCI FinalizeBlock instead of Commit
tzemanovic Oct 20, 2025
4918084
test: fix affected tests, ignore broken ETH tests
tzemanovic Oct 21, 2025
a2e70c2
test: add test for merkle tree restoration
tzemanovic Oct 21, 2025
48904ab
add cometBFT tx hash in tx events
tzemanovic Oct 6, 2025
88f0339
client: display cometBFT tx hash
tzemanovic Oct 6, 2025
f37d585
test/e2e: comet tx indexer
tzemanovic Oct 6, 2025
56f5878
changelog: #4901
tzemanovic Oct 6, 2025
eb51c96
node: add namada_tx_hash field to CometBFT tx result
tzemanovic Oct 7, 2025
49edf02
yeet all eth bridge related crates and code and light_sdk
tzemanovic Oct 24, 2025
06a447a
Merge branch 'main' into tomas/yeet-h
tzemanovic Oct 27, 2025
2dd5b26
make fmt
tzemanovic Oct 27, 2025
fe893c5
node: rm broadcaster
tzemanovic Oct 28, 2025
33c7179
make fmt
tzemanovic Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/unreleased/improvements/4901-comet-tx-indexer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Added tx event with CometBFT matching tx hash, which can be used to query
CometBFT tx indexer (if enabled) ([\#4901](https://github.com/namada-
net/namada/pull/4901))
1 change: 1 addition & 0 deletions .changelog/unreleased/miscellaneous/4618-comet-0.38.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Updated CometBFT to 0.38 ([\#4618](https://github.com/anoma/namada/pull/4618))
22 changes: 11 additions & 11 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:

rust-docs:
container:
image: ghcr.io/heliaxdev/namada-ci:namada-v2.3.0
image: ghcr.io/heliaxdev/namada-ci:namada-v3.0.0-alpha.1
runs-on: [self-hosted, 4vcpu-8ram-ubuntu22-namada-x86]
timeout-minutes: 20

Expand Down Expand Up @@ -91,7 +91,7 @@ jobs:

lints:
container:
image: ghcr.io/heliaxdev/namada-ci:namada-v2.3.0
image: ghcr.io/heliaxdev/namada-ci:namada-v3.0.0-alpha.1
runs-on: [self-hosted, 8vcpu-16ram-ubuntu22-namada-x86]
timeout-minutes: 15

Expand Down Expand Up @@ -129,7 +129,7 @@ jobs:
timeout-minutes: 10
runs-on: [self-hosted, 4vcpu-8ram-ubuntu22-namada-x86]
container:
image: ghcr.io/heliaxdev/namada-ci:namada-v2.3.0
image: ghcr.io/heliaxdev/namada-ci:namada-v3.0.0-alpha.1
strategy:
fail-fast: true
matrix:
Expand Down Expand Up @@ -176,7 +176,7 @@ jobs:
test-wasm:
timeout-minutes: 30
container:
image: ghcr.io/heliaxdev/namada-ci:namada-v2.3.0
image: ghcr.io/heliaxdev/namada-ci:namada-v3.0.0-alpha.1
runs-on: [self-hosted, 4vcpu-8ram-ubuntu22-namada-x86]
needs: [build-wasm]

Expand Down Expand Up @@ -223,7 +223,7 @@ jobs:
test-unit:
runs-on: [self-hosted, 8vcpu-16ram-ubuntu22-namada-x86]
container:
image: ghcr.io/heliaxdev/namada-ci:namada-v2.3.0
image: ghcr.io/heliaxdev/namada-ci:namada-v3.0.0-alpha.1
timeout-minutes: 30
needs: [build-wasm]

Expand Down Expand Up @@ -276,7 +276,7 @@ jobs:
check-packages:
runs-on: [self-hosted, 8vcpu-16ram-ubuntu22-namada-x86]
container:
image: ghcr.io/heliaxdev/namada-ci:namada-v2.3.0
image: ghcr.io/heliaxdev/namada-ci:namada-v3.0.0-alpha.1
timeout-minutes: 15

steps:
Expand Down Expand Up @@ -312,7 +312,7 @@ jobs:
test-integration:
runs-on: [self-hosted, 16vcpu-32ram-ubuntu22-namada-x86]
container:
image: ghcr.io/heliaxdev/namada-ci:namada-v2.3.0
image: ghcr.io/heliaxdev/namada-ci:namada-v3.0.0-alpha.1
timeout-minutes: 120
needs: [build-wasm]

Expand Down Expand Up @@ -365,7 +365,7 @@ jobs:
check-benchmarks:
runs-on: [self-hosted, 16vcpu-32ram-ubuntu22-namada-x86]
container:
image: ghcr.io/heliaxdev/namada-ci:namada-v2.3.0
image: ghcr.io/heliaxdev/namada-ci:namada-v3.0.0-alpha.1
if: github.event.pull_request.draft == false || contains(github.head_ref, 'mergify/merge-queue') || contains(github.ref_name, 'mergify/merge-queue')
timeout-minutes: 35
needs: [build-wasm]
Expand Down Expand Up @@ -413,7 +413,7 @@ jobs:
build-binaries:
runs-on: [self-hosted, 16vcpu-32ram-ubuntu22-namada-x86]
container:
image: ghcr.io/heliaxdev/namada-ci:namada-v2.3.0
image: ghcr.io/heliaxdev/namada-ci:namada-v3.0.0-alpha.1
timeout-minutes: 25

steps:
Expand Down Expand Up @@ -464,7 +464,7 @@ jobs:
test-e2e:
runs-on: [self-hosted, 4vcpu-8ram-ubuntu22-namada-x86]
container:
image: ghcr.io/heliaxdev/namada-ci:namada-v2.3.0
image: ghcr.io/heliaxdev/namada-ci:namada-v3.0.0-alpha.1
if: github.event.pull_request.draft == false || contains(github.head_ref, 'mergify/merge-queue') || contains(github.ref_name, 'mergify/merge-queue')
needs: [build-wasm, build-binaries]
timeout-minutes: 50
Expand Down Expand Up @@ -635,7 +635,7 @@ jobs:
test-e2e-with-device-automation:
runs-on: [self-hosted, 4vcpu-8ram-ubuntu22-namada-x86]
container:
image: ghcr.io/heliaxdev/namada-ci:namada-v2.3.0
image: ghcr.io/heliaxdev/namada-ci:namada-v3.0.0-alpha.1
if: github.event.pull_request.draft == false || contains(github.head_ref, 'mergify/merge-queue') || contains(github.ref_name, 'mergify/merge-queue')
needs: [build-wasm, build-binaries]
timeout-minutes: 50
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
wasm:
runs-on: [ubuntu-latest]
container:
image: ghcr.io/heliaxdev/namada-ci:namada-v2.3.0
image: ghcr.io/heliaxdev/namada-ci:namada-v3.0.0-alpha.1
steps:
- name: Checkout repo
uses: actions/checkout@v4
Expand Down Expand Up @@ -114,4 +114,4 @@ jobs:
draft: true
files: ./**/*.tar.gz
tag_name: ${{ steps.get_version.outputs.version }}
name: Namada ${{ steps.get_version.outputs.version-without-v }}
name: Namada ${{ steps.get_version.outputs.version-without-v }}
2 changes: 1 addition & 1 deletion .github/workflows/scripts/hermes.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.13.0
0.0.1-namada-comet-0.38
71 changes: 0 additions & 71 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 0 additions & 6 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,11 @@ members = [
"crates/controller",
"crates/core",
"crates/encoding_spec",
"crates/ethereum_bridge",
"crates/events",
"crates/gas",
"crates/governance",
"crates/ibc",
"crates/io",
"crates/light_sdk",
"crates/macros",
"crates/migrations",
"crates/merkle_tree",
Expand All @@ -37,7 +35,6 @@ members = [
"crates/tx_prelude",
"crates/vm",
"crates/vm_env",
"crates/vote_ext",
"crates/vp",
"crates/vp_env",
"crates/vp_prelude",
Expand Down Expand Up @@ -71,13 +68,11 @@ namada_apps_lib = { version = "0.251.0", path = "crates/apps_lib" }
namada_controller = { version = "0.251.0", path = "crates/controller" }
namada_core = { version = "0.251.0", path = "crates/core" }
namada_encoding_spec = { version = "0.251.0", path = "crates/encoding_spec" }
namada_ethereum_bridge = { version = "0.251.0", path = "crates/ethereum_bridge" }
namada_events = { version = "0.251.0", path = "crates/events" }
namada_gas = { version = "0.251.0", path = "crates/gas" }
namada_governance = { version = "0.251.0", path = "crates/governance" }
namada_ibc = { version = "0.251.0", path = "crates/ibc" }
namada_io = { version = "0.251.0", path = "crates/io" }
namada_light_sdk = { version = "0.251.0", path = "crates/light_sdk" }
namada_macros = { version = "0.251.0", path = "crates/macros" }
namada_migrations = { version = "0.251.0", path = "crates/migrations" }
namada_merkle_tree = { version = "0.251.0", path = "crates/merkle_tree" }
Expand All @@ -99,7 +94,6 @@ namada_tx_env = { version = "0.251.0", path = "crates/tx_env" }
namada_tx_prelude = { version = "0.251.0", path = "crates/tx_prelude" }
namada_vm = { version = "0.251.0", path = "crates/vm", default-features = false }
namada_vm_env = { version = "0.251.0", path = "crates/vm_env" }
namada_vote_ext = { version = "0.251.0", path = "crates/vote_ext" }
namada_vp = { version = "0.251.0", path = "crates/vp" }
namada_vp_env = { version = "0.251.0", path = "crates/vp_env" }
namada_vp_prelude = { version = "0.251.0", path = "crates/vp_prelude" }
Expand Down
3 changes: 0 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,10 @@ crates += namada_apps_lib
crates += namada_benchmarks
crates += namada_core
crates += namada_encoding_spec
crates += namada_ethereum_bridge
crates += namada_events
crates += namada_gas
crates += namada_governance
crates += namada_ibc
crates += namada_light_sdk
crates += namada_macros
crates += namada_merkle_tree
crates += namada_parameters
Expand All @@ -61,7 +59,6 @@ crates += namada_tx_env
crates += namada_tx_prelude
crates += namada_vm
crates += namada_vm_env
crates += namada_vote_ext
crates += namada_vp
crates += namada_vp_env
crates += namada_vp_prelude
Expand Down
1 change: 0 additions & 1 deletion crates/apps/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ default = ["migrations"]
mainnet = ["namada_apps_lib/mainnet"]
jemalloc = ["namada_node/jemalloc"]
migrations = ["namada_apps_lib/migrations"]
namada-eth-bridge = ["namada_apps_lib/namada-eth-bridge"]

[dependencies]
namada_apps_lib.workspace = true
Expand Down
5 changes: 0 additions & 5 deletions crates/apps/src/bin/namada/cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ fn handle_command(cmd: cli::cmds::Namada, raw_sub_cmd: String) -> Result<()> {
cmd,
cli::cmds::Namada::Node(_)
| cli::cmds::Namada::Client(_)
| cli::cmds::Namada::Relayer(_)
| cli::cmds::Namada::Wallet(_)
);

Expand Down Expand Up @@ -58,9 +57,6 @@ fn handle_command(cmd: cli::cmds::Namada, raw_sub_cmd: String) -> Result<()> {
handle_subcommand("namadac", sub_args)
}
cli::cmds::Namada::Wallet(_) => handle_subcommand("namadaw", sub_args),
cli::cmds::Namada::Relayer(_) | cli::cmds::Namada::EthBridgePool(_) => {
handle_subcommand("namadar", sub_args)
}
cli::cmds::Namada::Complete(cli::cmds::Complete(
cli::args::Complete { shell },
)) => {
Expand All @@ -75,7 +71,6 @@ fn handle_command(cmd: cli::cmds::Namada, raw_sub_cmd: String) -> Result<()> {
(cli::namada_node_app(version), "namadan"),
(cli::namada_client_app(version), "namadac"),
(cli::namada_wallet_app(version), "namadaw"),
(cli::namada_relayer_app(version), "namadar"),
] {
match shell {
cli::args::Shell::Bash => {
Expand Down
1 change: 0 additions & 1 deletion crates/apps_lib/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ mainnet = ["namada_sdk/mainnet"]
testing = ["lazy_static", "namada_sdk/testing"]
benches = ["lazy_static", "namada_sdk/benches"]
migrations = ["namada_migrations", "namada_sdk/migrations", "linkme"]
namada-eth-bridge = ["namada_sdk/namada-eth-bridge"]

[dependencies]
namada_core.workspace = true
Expand Down
Loading
Loading