Skip to content

Mandatory IBC shielded action fees #4981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sug0 wants to merge 85 commits into
base: main
Choose a base branch
from
Open

Mandatory IBC shielded action fees #4981

sug0 wants to merge 85 commits into from

Conversation

@sug0
Copy link
Collaborator

@sug0 sug0 commented Nov 17, 2025 •
edited
Loading

Describe your changes

Based on #4945
Review: https://github.com/namada-net/namada/pull/4981/files/0d34825034bc49b2536e5754e16445cfa42cb86f..b1df77c746d8c13ac14c1230363f3a703f0b27c9

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

sug0 added 30 commits October 27, 2025 13:15
@sug0
Implement IBC account ids
6c81768
@sug0
Insert MASP as verifier from IBC payment addr signer
f8be657
@sug0
Rename is_shielded field to has_masp_tx
ae2948a
@sug0
Add shielded token store
c8ef30e
@sug0
Integrate shielded token store with IBC VP
4ba43bd
@sug0
Encode MASP payment addrs with bech32 legacy codec
d3d7d4e
@sug0
Create note from MASP payment addr
4f55905
@sug0
IBC account id helper predicates
fe8b410
@sug0
Make IBC amount conversions infallible
ca6d710
@sug0
Mint MASP notes via IBC
7d417a1
@sug0
Remove storage impls from ibc protocol ctx
2f72d1c
@sug0
Simplify params bounds in ibc transfer def
cf07ab2
@sug0
Integrate transparent token store with IBC VP
ce601ae
@sug0
Read token denom from storage when minting MASP note
5e10bab
@sug0
Keep track of nr of MASP IBC shieldings
6ba4f78
@sug0
Seed MASP note with IBC shielding counter
bb2530e
@sug0
Integrate params store with IBC transfer ctx
2349e6d
@sug0
Add convenience method to compute MASP epoch
f9d7307
@sug0
Expose storage predicate to check if a conversion exists
95b0d86
@sug0
Attribute epochs to shielded IBC assets
83dddcb
@sug0
Remove unused type
b9bef5e
@sug0
Relocate compact notes to core
750b37d
@sug0
Serde serialize compact notes
8c1d4ea
@sug0
Add new type of MASP event for unencypted notes
5c8ceda
@sug0
Make IBC ctx event emission generic
54d1172
@sug0
Emit MASP shielding events from IBC ctx
ecd471d
@sug0
Replace tx index with more generic indexed tx in protocol
4b78ec2
@sug0
Store indexed tx in tx/vp ctx
3784571
@sug0
Repurpose get_tx_index host fn to retrieve indexed tx
d71ff69
@sug0
Create indexed tx from tuple
a7c4389
@sug0 sug0 added IBC MASP breaking-change breaking:consensus Consensus breaking change that requires a hard-fork do-not-merge Do not merge for now labels Nov 17, 2025
@sug0 sug0 changed the title Tiago/mandatory ibc shielded action fees Mandatory IBC shielded action fees Nov 17, 2025
@github-actions github-actions bot added the breaking:api public API breaking change label Nov 17, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 17, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 345dd1f.

🟢 All jobs passed!

But CI Insights is watching 👀

@sug0 sug0 force-pushed the tiago/mandatory-ibc-shielded-action-fees branch from 9e19e60 to b1df77c Compare November 18, 2025 09:36
@sug0 sug0 force-pushed the tiago/mandatory-ibc-shielded-action-fees branch from 168ccc8 to 345dd1f Compare November 27, 2025 14:28
@brentstone brentstone added this to the Current Priorities milestone Dec 6, 2025
sug0 added 2 commits December 18, 2025 14:23
@sug0
wip
d12d23c
@sug0
wip2
f56ba17 
there is still a bug. when refunding a packet, we're charging
unshielding fees, for some reason :\
@sug0 sug0 force-pushed the tiago/mandatory-ibc-shielded-action-fees branch from 2102979 to f56ba17 Compare December 19, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking:api public API breaking change breaking:consensus Consensus breaking change that requires a hard-fork breaking-change do-not-merge Do not merge for now IBC MASP

Projects

None yet

Milestone

Priorities > v201.0.7

Development

Successfully merging this pull request may close these issues.

4 participants

@sug0 @brentstone @yito88