Skip to content

Conversation

@lorenzwidmer
Copy link

Fixes #1503.

@lorenzwidmer
Copy link
Author

There is another bug that can cause low GPU utilisation and has been fixed in the last commit (a6d38c4). I think this is the underlying cause for us really noticing the slow encoding in some cases. In the worst case, it can prevent all threads from encoding for several minutes if the reference file contains regions that are not found in the alignment.

The problem is that bam_itr_querys() can return a null pointer rather than an iterator if the region is not found in the BAM. This is not checked in dorado::secondary::calculate_pileup() and can result in high IO usage and very long pileup durations for non-existent regions in large BAM files (or BAMs with a large header).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dorado polish low GPU utilisation for bam regions of variable coverage

1 participant