Skip to content

solve: HoTT 3.2#86

Open
kiwiyou wants to merge 3 commits intomainfrom
solve/hott-3.2
Open

solve: HoTT 3.2#86
kiwiyou wants to merge 3 commits intomainfrom
solve/hott-3.2

Conversation

@kiwiyou
Copy link
Contributor

@kiwiyou kiwiyou commented Feb 1, 2026

image

@gemini-code-assist
Copy link

Summary of Changes

Hello @kiwiyou, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new formal proof for a fundamental theorem in Homotopy Type Theory (HoTT), specifically demonstrating that the sum type of two sets is also a set. The proof meticulously constructs an auxiliary type family to manage equality within sum types, then establishes its propositional nature and equivalence to the standard equality. Finally, it leverages advanced HoTT concepts like univalence and transport to formally derive the desired set property for the sum type.

Highlights

  • New Formal Proof Added: A new file, HoTT-3.2.typ, has been added containing a formal proof for Homotopy Type Theory (HoTT) 3.2. This proof demonstrates that if A and B are sets, then their sum type A + B is also a set.
  • Encode-Decode Method for Sum Type Equality: The proof introduces and utilizes an 'encode-decode' method with a code(x, y) type family to handle equality within sum types, specifically addressing degenerate cases like inl = inr.
  • Proof of Propositional Nature and Equivalence: The proof formally establishes that code(x, y) is a proposition (isProp(code(x, y))) and demonstrates its equivalence to the standard equality (x eq(A + B) y).
  • Application of Univalence and Transport: The final step of the proof leverages the principles of univalence and transport to formally construct and verify the isSet(A + B) property, concluding that the sum of two sets is indeed a set.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a solution for HoTT exercise 3.2, which is well-structured and uses typst features effectively. I've found a few issues in the mathematical text that could affect the correctness and clarity of the proof's description. Specifically, there's a likely typo in the definition of decode and some inaccuracies in the explanatory text for the equivalence proof. I've provided suggestions to correct these points.

@kiwiyou
Copy link
Contributor Author

kiwiyou commented Feb 1, 2026

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a solution to exercise 3.2 from the HoTT book. The proof is well-structured and follows the encode-decode method correctly to show that the sum of two sets is a set. The overall logic is sound. I've added a couple of suggestions to improve the notational clarity in the derivation steps of the proof, making them more formally rigorous.

Comment on lines +73 to +78
encode(x, y, decode(x, y, c))
&equiv encode(inl(a), inl(a), decode(inl(a), inl(a), refl_a)) \
&equiv encode(inl(a), inl(a), ap_inl (refl_a)) \
&equiv encode(inl(a), inl(a), refl_inl(a)) \
&equiv refl_a \
&equiv c

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The first step in this chain of equivalences is an instantiation based on the path induction mentioned in the preceding text, rather than a formal equivalence. This can be confusing. For better clarity and formal rigor, it's better to start the calculation directly from the instantiated expression.

    encode(inl(a), inl(a), decode(inl(a), inl(a), refl_a)) \
    &equiv encode(inl(a), inl(a), ap_inl (refl_a)) \
    &equiv encode(inl(a), inl(a), refl_inl(a)) \
    &equiv refl_a \
    &equiv c

Comment on lines +85 to +90
decode(x, y, encode(x, y, p))
&equiv decode(inl(a), inl(a), encode(inl(a), inl(a), refl_inl(a))) \
&equiv decode(inl(a), inl(a), refl_a) \
&equiv ap_inl (refl_a) \
&equiv refl_inl(a) \
&equiv p

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the previous proof, this chain of equivalences starts with an instantiation rather than a formal equivalence step. To improve clarity and rigor, the calculation should begin directly with the instantiated expression.

    decode(inl(a), inl(a), encode(inl(a), inl(a), refl_inl(a))) \
    &equiv decode(inl(a), inl(a), refl_a) \
    &equiv ap_inl (refl_a) \
    &equiv refl_inl(a) \
    &equiv p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant