Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

El3314 Driver #121

Merged
merged 4 commits into from
Jan 6, 2025
Merged

El3314 Driver #121

merged 4 commits into from
Jan 6, 2025

Conversation

kwehage
Copy link
Collaborator

@kwehage kwehage commented Jan 6, 2025

Add driver for the EL3314 Beckhoff module.

This was mostly a copy and paste job from the EL3318 driver. Brendan and I tested this on the Citadel cryogenic testbed and verified we can successfully read temperatures lower than -200C using type T thermocouples. Note the 3318 module will not report temperatures lower than -200C, even though type T thermocouples can be used in lower temperature ranges.

@kwehage kwehage requested a review from preston-rogers January 6, 2025 23:21
@kwehage kwehage requested review from dwai-wai and removed request for preston-rogers January 6, 2025 23:22
@kwehage kwehage assigned dwai-wai and unassigned preston-rogers Jan 6, 2025
Copy link
Contributor

@dwai-wai dwai-wai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this driver and doing the testing

@kwehage kwehage merged commit eb8ebaa into master Jan 6, 2025
2 checks passed
@kwehage kwehage deleted the kwehage-el3314 branch January 6, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants