fix: replace numpy 2.0 removed APIs (np.NaN, np.float)#156
Open
yasumorishima wants to merge 2 commits intonasa:masterfrom
Open
fix: replace numpy 2.0 removed APIs (np.NaN, np.float)#156yasumorishima wants to merge 2 commits intonasa:masterfrom
yasumorishima wants to merge 2 commits intonasa:masterfrom
Conversation
- Replace np.NaN with np.nan (8 occurrences across 4 files) - Replace np.float with np.float64 (2 occurrences across 2 files) - Update numpy version constraint: numpy<2.0.0 -> numpy>=1.24.0 in both setup.cfg and requirements.txt Resolves nasa#154
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
np.NaNwithnp.nan(8 occurrences across 4 files)np.floatwithnp.float64(2 occurrences across 2 files)numpy<2.0.0→numpy>=1.24.0in bothsetup.cfgandrequirements.txtResolves #154
Changes
kamodo_ccmc/flythrough/SF_output.pynp.NaN→np.nankamodo_ccmc/readers/adelphi_tocdf.pynp.NaN→np.nan(2)kamodo_ccmc/readers/superdarn_tocdf.pynp.NaN→np.nan(3)kamodo_ccmc/readers/verb3d_4D.pynp.NaN→np.nan(2)kamodo_ccmc/readers/hapi.pynp.float→np.float64kamodo_ccmc/readers/swmf_gm_octree.pynp.float→np.float64setup.cfgnumpy<2.0.0→numpy>=1.24.0requirements.txtnumpy<2.0.0→numpy>=1.24.0Context
np.NaNandnp.floatwere removed in NumPy 2.0 (migration guide). This PR updates all usages inkamodo_ccmcto their supported replacements.Note: The base
kamodopackage (nasa/Kamodo-core) also requires numpy 2.0 fixes — a companion PR has been submitted there.