Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test tutorials workflow #201

Open
wants to merge 26 commits into
base: dev
Choose a base branch
from
Open

Fix test tutorials workflow #201

wants to merge 26 commits into from

Conversation

lymichelle21
Copy link

@lymichelle21 lymichelle21 commented Mar 25, 2025

Address #198

  • Update test_tutorials to run every tutorial
    • Split into tests_tutorials and tests_tutorials_part_two to limit timeout issues
  • Add temporary placeholder to ignore test_examples - will need to be removed as a requirement (in progress)
  • Add temporary placeholder to ignore benchmarking - will need to be fixed (noted in Add benchmarking #203)

Copy link

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

@lymichelle21 lymichelle21 added bug Something isn't working tests Updates to tests, benchmarking or CI/CD infrastructure labels Mar 25, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.65%. Comparing base (e7491d5) to head (68f6aca).
Report is 24 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #201   +/-   ##
=======================================
  Coverage   83.64%   83.65%           
=======================================
  Files         102      102           
  Lines       10852    10857    +5     
=======================================
+ Hits         9077     9082    +5     
  Misses       1775     1775           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lymichelle21 lymichelle21 marked this pull request as ready for review March 31, 2025 21:28
Copy link
Contributor

@kjjarvis kjjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Just one question to make sure only necessary changes are checked in (I'm not sure - you know best!)

@lymichelle21 lymichelle21 marked this pull request as draft April 2, 2025 20:45
@lymichelle21 lymichelle21 marked this pull request as ready for review April 3, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests Updates to tests, benchmarking or CI/CD infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants