Skip to content

Update parameter estimation notebook#202

Merged
teubert merged 12 commits into
devfrom
update-notebook-2
Apr 7, 2025
Merged

Update parameter estimation notebook#202
teubert merged 12 commits into
devfrom
update-notebook-2

Conversation

@lymichelle21

Copy link
Copy Markdown
Contributor
  • Add table of contents
  • Fix formatting for consistency

@github-actions

Copy link
Copy Markdown

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

@lymichelle21 lymichelle21 added the documentation Improvements or additions to documentation, examples, or tutorial label Mar 31, 2025
@lymichelle21 lymichelle21 marked this pull request as ready for review March 31, 2025 21:29

@kjjarvis kjjarvis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great. I like the consistency a lot! Just a couple minor edits (all based on the previous work that was done, not the new stuff). And one question regarding the metadata in the notebook. Great work!

Comment thread examples/02_Parameter Estimation.ipynb Outdated
Comment thread examples/02_Parameter Estimation.ipynb Outdated
Comment thread examples/02_Parameter Estimation.ipynb Outdated

@teubert teubert left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few cosmetic suggestions (including some for lines you didn't touch). But overall it looks great! Good work!

Comment thread examples/02_Parameter Estimation.ipynb Outdated
Comment thread examples/02_Parameter Estimation.ipynb Outdated
Comment thread examples/02_Parameter Estimation.ipynb Outdated
Comment thread examples/02_Parameter Estimation.ipynb Outdated
Comment thread examples/02_Parameter Estimation.ipynb Outdated
Comment thread examples/02_Parameter Estimation.ipynb Outdated
Comment thread examples/02_Parameter Estimation.ipynb Outdated
Comment thread examples/02_Parameter Estimation.ipynb Outdated
Comment thread examples/02_Parameter Estimation.ipynb
Comment thread examples/02_Parameter Estimation.ipynb Outdated
Co-authored-by: Christopher Teubert <christopher.a.teubert@nasa.gov>

@kjjarvis kjjarvis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions and edits! Thanks for working so hard on this

@teubert teubert merged commit 54b6155 into dev Apr 7, 2025
@lymichelle21 lymichelle21 deleted the update-notebook-2 branch April 8, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation, examples, or tutorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants