-
Notifications
You must be signed in to change notification settings - Fork 18
Update parameter estimation notebook #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lymichelle21
commented
Mar 31, 2025
- Add table of contents
- Fix formatting for consistency
Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look great. I like the consistency a lot! Just a couple minor edits (all based on the previous work that was done, not the new stuff). And one question regarding the metadata in the notebook. Great work!
Co-authored-by: Katy Jarvis Griffith <[email protected]>
This reverts commit af27c02.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few cosmetic suggestions (including some for lines you didn't touch). But overall it looks great! Good work!
Co-authored-by: Christopher Teubert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great additions and edits! Thanks for working so hard on this