Skip to content

Update parameter estimation notebook #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 7, 2025
Merged

Update parameter estimation notebook #202

merged 12 commits into from
Apr 7, 2025

Conversation

lymichelle21
Copy link
Contributor

  • Add table of contents
  • Fix formatting for consistency

Copy link

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

@lymichelle21 lymichelle21 added the documentation Improvements or additions to documentation, examples, or tutorial label Mar 31, 2025
@lymichelle21 lymichelle21 marked this pull request as ready for review March 31, 2025 21:29
Copy link
Contributor

@kjjarvis kjjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great. I like the consistency a lot! Just a couple minor edits (all based on the previous work that was done, not the new stuff). And one question regarding the metadata in the notebook. Great work!

Copy link
Contributor

@teubert teubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few cosmetic suggestions (including some for lines you didn't touch). But overall it looks great! Good work!

Co-authored-by: Christopher Teubert <[email protected]>
Copy link
Contributor

@kjjarvis kjjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions and edits! Thanks for working so hard on this

@teubert teubert merged commit 54b6155 into dev Apr 7, 2025
29 checks passed
@lymichelle21 lymichelle21 deleted the update-notebook-2 branch April 8, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation, examples, or tutorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants