Update parameter estimation notebook#202
Merged
Merged
Conversation
lymichelle21
commented
Mar 31, 2025
Contributor
- Add table of contents
- Fix formatting for consistency
|
Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:
|
kjjarvis
requested changes
Apr 2, 2025
kjjarvis
left a comment
Contributor
There was a problem hiding this comment.
These changes look great. I like the consistency a lot! Just a couple minor edits (all based on the previous work that was done, not the new stuff). And one question regarding the metadata in the notebook. Great work!
Co-authored-by: Katy Jarvis Griffith <55932920+kjjarvis@users.noreply.github.com>
This reverts commit af27c02.
teubert
approved these changes
Apr 4, 2025
teubert
left a comment
Contributor
There was a problem hiding this comment.
A few cosmetic suggestions (including some for lines you didn't touch). But overall it looks great! Good work!
Co-authored-by: Christopher Teubert <christopher.a.teubert@nasa.gov>
kjjarvis
approved these changes
Apr 7, 2025
kjjarvis
left a comment
Contributor
There was a problem hiding this comment.
Great additions and edits! Thanks for working so hard on this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.