Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump JSS to ^8.1.0 #46

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Bump JSS to ^8.1.0 #46

wants to merge 6 commits into from

Conversation

RikardGehlin
Copy link

Also fixed breaking changes from migration between 7.1.7 to 8.1.0 https://github.com/cssinjs/jss/blob/v8.1.0/changelog.md#800--2017-06-20

breaking changes were:

  • moved DOM renderer
  • deprecation of generateClassName option in jss.createStylesheet, now you have to provide createGenerateClassName factory when you create jss

@RikardGehlin
Copy link
Author

RikardGehlin commented Jul 17, 2017

as far as API surface isn't changed it's not a breaking change for consumers, but it's sort of big deal, so perhaps it's a minor release

@codecov
Copy link

codecov bot commented Jul 17, 2017

Codecov Report

Merging #46 into master will increase coverage by 0.09%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   94.11%   94.21%   +0.09%     
==========================================
  Files           4        4              
  Lines         119      121       +2     
==========================================
+ Hits          112      114       +2     
  Misses          7        7
Impacted Files Coverage Δ
src/styleManager.js 96.92% <ø> (+1.03%) ⬆️
src/ThemeProvider.js 80.76% <90.9%> (+5.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc03b1...2b9fc6c. Read the comment docs.

@RikardGehlin
Copy link
Author

i dont know how to fix flow errors

@RikardGehlin
Copy link
Author

@nathanmarks can you help?

@kof
Copy link
Contributor

kof commented Jul 17, 2017

I think you should wait a bit, because @oliviertassinari is cooking something in this regard.

@iamstarkov
Copy link

sure, but we migrated it and fixed the breaking changes. we just dont know how to fix flow erros

@iamstarkov
Copy link

we need this because we need latest jss checked out in our projects for it to be possible to migrate to react-jss's theming

@iamstarkov
Copy link

btw, published as @iamstarkov/[email protected]

@oliviertassinari
Copy link

oliviertassinari commented Jul 17, 2017

I'm working on a major styling upgrade on the Material-UI side, we would no longer rely on jss-theme-reactor. Some of the features this rewrite is unlocking:

  • better perf
  • theme nesting
  • simpler injection order handling
  • pure component logic dodge
  • shorter className in production

@iamstarkov
Copy link

@oliviertassinari thats cool, but we do use jss-theme-reactor without material-ui, so we need release of jss-theme-reactor to depend on latest jss, so we can migrate to react-jss's theming. can we get such a release?

@iamstarkov
Copy link

so, just clarify we dont need new material-ui release, we need new release of jss-theme-reactor

@oliviertassinari
Copy link

@iamstarkov Oh but I don't have any admin right on this repository.

@iamstarkov
Copy link

@nathanmarks can you help?

@iamstarkov
Copy link

@nathanmarks ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants