Fix release workflow#60
Merged
Merged
Conversation
The push-to-main trigger meant any merged PR that changed version.txt would push packages to NuGet. Require a GitHub release instead, and validate that the tag matches version.txt before packing.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
=======================================
Coverage 85.61% 85.61%
=======================================
Files 51 51
Lines 723 723
Branches 90 90
=======================================
Hits 619 619
Misses 77 77
Partials 27 27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow triggered on push to main, so any merged PR that changed version.txt would push packages to NuGet. Switch to the
release: publishedevent so publishing requires a maintainer to create a GitHub release, and validate the tag matches version.txt before packing.