Descriptive stream & consumer health errors #6416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server/jetstream_cluster.go
Outdated
| js.mu.RUnlock() | ||
| return false | ||
| return fmt.Errorf("stream assignment or group missing") |
There was a problem hiding this comment.
If not formatting used maybe errors.New()?
This should make the output of `healthz` less opaque when there are stream or consumer healthcheck errors. Signed-off-by: Neil Twigg <[email protected]>
neilalexander
force-pushed
the
neil/streamconsumerhealth
branch
from
0c7fbd3 to
f3c06cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make the output of
healthzless opaque when there are stream or consumer healthcheck errors. Also more closely aligns the checks between streams and consumers.Signed-off-by: Neil Twigg [email protected]