Allow fractional connection durations - #1001
Open
attilaolah wants to merge 1 commit into
Open
Conversation
Correct the public duration annotations to match asyncio's fractional-second support. Assisted-by: OpenCode:gpt-5.6-terra ruff ty Signed-off-by: Attila Oláh <attila@dorn.haus>
Author
|
It would be even nicer to accept This PR is trying to keep it minimal and only make a typing correction, no runtime change is intended. |
caspervonb
self-requested a review
August 17, 2026 08:44
caspervonb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1000.
Updates the public Client.connect() annotations for connect_timeout and reconnect_time_wait to float, matching their use as asyncio durations. Integer callers remain supported.
Validation: