fix: exception type - #1008
Open
superlevure wants to merge 2 commits into
Open
Conversation
fallenmi
approved these changes
Aug 26, 2026
fallenmi
left a comment
There was a problem hiding this comment.
Reviewed with Codex at exact head dcf8fcd.
I independently exercised all three modified timeout exits against the exact base and head: 90 deterministic base executions raised asyncio.TimeoutError, while 90 exact-head executions raised FetchTimeoutError. The latter remains catchable through the documented nats.errors.TimeoutError base class, restoring the pre-2.15 public exception contract across the initial no-wait timeout and both exhausted-deadline branches.
The touched module also compiles cleanly, the patch passes git diff --check, and all 27 live checks are green. The head and zero-feedback state were unchanged immediately before submission.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tentative fix for https://github.com/nats-io/nats.py/pull/934/changes#r3823522044