Skip to content

fix: exception type - #1008

Open
superlevure wants to merge 2 commits into
nats-io:mainfrom
superlevure:fix/timeout-exception-type
Open

fix: exception type#1008
superlevure wants to merge 2 commits into
nats-io:mainfrom
superlevure:fix/timeout-exception-type

Conversation

@superlevure

Copy link
Copy Markdown

@fallenmi fallenmi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with Codex at exact head dcf8fcd.

I independently exercised all three modified timeout exits against the exact base and head: 90 deterministic base executions raised asyncio.TimeoutError, while 90 exact-head executions raised FetchTimeoutError. The latter remains catchable through the documented nats.errors.TimeoutError base class, restoring the pre-2.15 public exception contract across the initial no-wait timeout and both exhausted-deadline branches.

The touched module also compiles cleanly, the patch passes git diff --check, and all 27 live checks are green. The head and zero-feedback state were unchanged immediately before submission.

@caspervonb caspervonb added the nats-legacy Legacy asyncio NATS client label Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nats-legacy Legacy asyncio NATS client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants