Populate KeyValue Entry.created from message timestamp - #989
Conversation
KeyValue.get() hardcoded Entry.created to None, so callers had no creation time for a fetched key and purge_deletes-style age math on a fetched entry was impossible. Both the direct-get and API-get paths already carry the message timestamp on RawStreamMsg.time, so use it.
|
Claude finished @caspervonb's task in 1m 21s —— View job PR Review
The fix is correct. One pre-existing issue worth fixing here: # kv.py line 95 — fix the annotation
created: Optional[datetime.datetime]Test coverage is good: the new test exercises both |
KeyValue.get()hardcodedEntry.createdtoNone, so callers had no creation time for a fetched key. Both the direct-get and API-get paths already carry the timestamp onRawStreamMsg.time; use it.Fixes #398.