Honor ConsumerConfig.durable_name in pull_subscribe - #992
Conversation
When durable was passed only through the config (not the durable argument), pull_subscribe generated an ephemeral name while leaving the user's durable_name set, so the server rejected the mismatched request. Resolve the durable from config.durable_name before the lookup so it is created and bound as a durable.
|
Claude finished @caspervonb's task in 1m 27s —— View job Code Review
The fix is correct and minimal. The root cause was clear: The placement of the new check (after stream lookup, before the One minor gap in the test: it only verifies the consumer exists after a single subscribe call. It doesn't verify that calling No correctness bugs, no security or async pattern issues. The fix is ready to merge as-is; the second test case would be a nice addition but is not blocking. |
When the durable was supplied only through the config,
pull_subscribegenerated an ephemeral name while leavingdurable_nameset, so the server rejected the mismatched request. Resolve the durable fromconfig.durable_namebefore the lookup.Fixes #603.