Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html endpoint #3647

Closed
wants to merge 5 commits into from
Closed

Html endpoint #3647

wants to merge 5 commits into from

Conversation

dbolack-ab
Copy link
Collaborator

@dbolack-ab dbolack-ab commented Aug 19, 2024

A possible solution for the HTML-only output using the existing sharePage logic rather than restoring the old printPage.

Solves #956
Possibly solves #661

  • Test on phones to see if solves margin-*: auto readability issues, sort out how to remove margin styling
  • Add to menu bar
  • Discuss if a better path name ( embed? export? ) should be used.
  • Verify works for embedding.

test using .../html/shareId

This provides an /html/ endpoint which uses a stripped down version of the share page.
@calculuschild calculuschild temporarily deployed to homebrewery-pr-3647 August 20, 2024 17:44 Inactive
@calculuschild calculuschild temporarily deployed to homebrewery-pr-3647 August 20, 2024 18:25 Inactive
@calculuschild calculuschild temporarily deployed to homebrewery-pr-3647 August 20, 2024 18:37 Inactive
@calculuschild
Copy link
Member

calculuschild commented Aug 23, 2024

This puts new stuff into the sharePage, but then ignores almost all of the sharePage logic. If we have to basically bypass the whole sharePage output, that seems to me a sign that it really just needs to be its own dedicated page.

I think this might be worthwhile to just take the old /print page as a starting point, and then strip it down to the very minimum (doesn't need to deal with loading values from /new, etc).

@calculuschild
Copy link
Member

calculuschild commented Aug 23, 2024

By the way, I don't think this solves either of #661 or #956, though a plain HTML view was requested separately on Reddit.

My understanding from reading those issues is that they want a bundle of CSS + HTML they can copy and host on their own website, so more a download link than an HTML view. In any case, we should not encourage users hot-embedding our site; we are not a CDN to host files for other people's web pages.

@dbolack-ab dbolack-ab closed this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants