Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault fixes #4080

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Vault fixes #4080

wants to merge 11 commits into from

Conversation

5e-Cleric
Copy link
Member

@5e-Cleric 5e-Cleric commented Mar 8, 2025

For some time, I've wanted to fix some things i wasn't perfectly loving about the page, so this is the time to fix them:

  • Fix bug with pagination not updating (Fixes issue Vault search does not render pagination correctly when page size is changed #4079)
  • Pagination now will not appear when less than 10 total brews are found
  • Fixed issue with small text having an extra space character
  • Fix styling for narrow screens and narrow panel
  • display pagination on top part of the panel if the page size is over 10 brews
  • Now, the searching text will only appear if no brews are already displaying, otherwise, fast searches showed it for a few milliseconds, looking like a weird glitch
  • lint all related files

@5e-Cleric 5e-Cleric temporarily deployed to homebrewery-pr-4080 March 8, 2025 12:30 Inactive
@5e-Cleric 5e-Cleric temporarily deployed to homebrewery-pr-4080 March 8, 2025 12:39 Inactive
@5e-Cleric 5e-Cleric temporarily deployed to homebrewery-pr-4080 March 8, 2025 12:42 Inactive
@5e-Cleric 5e-Cleric temporarily deployed to homebrewery-pr-4080 March 8, 2025 12:43 Inactive
@5e-Cleric 5e-Cleric temporarily deployed to homebrewery-pr-4080 March 8, 2025 12:46 Inactive
@5e-Cleric 5e-Cleric temporarily deployed to homebrewery-pr-4080 March 8, 2025 16:16 Inactive
@5e-Cleric 5e-Cleric temporarily deployed to homebrewery-pr-4080 March 8, 2025 16:28 Inactive
@5e-Cleric 5e-Cleric temporarily deployed to homebrewery-pr-4080 March 8, 2025 18:32 Inactive
@5e-Cleric 5e-Cleric temporarily deployed to homebrewery-pr-4080 March 8, 2025 18:35 Inactive
@5e-Cleric 5e-Cleric requested a review from Gazook89 March 10, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔍 R0 - Needs first review 👀 PR ready but has not been reviewed tweak Small, non-breaking change
Projects
Status: Waiting for Calc's First Review
Development

Successfully merging this pull request may close these issues.

Vault search does not render pagination correctly when page size is changed
2 participants