Skip to content

Patch 1 #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Patch 1 #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e65f440
Fix view error when displaying a peerendpointaddressfamily with no as…
RaidAndFade May 25, 2025
a07f0a6
Create 248.fixed
RaidAndFade May 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/248.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix view error when displaying a peerendpointaddressfamily with no associated bgproutinginstance
6 changes: 5 additions & 1 deletion nautobot_bgp_models/templates/nautobot_bgp_models/peerendpointaddressfamily_retrieve.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,11 @@
</tr>
<tr>
<td>Routing Instance</td>
<td><a href="{% url 'plugins:nautobot_bgp_models:bgproutinginstance' pk=object.peer_endpoint.routing_instance.pk %}">{{ object.peer_endpoint.routing_instance }}</a></td>
{% if object.peer_endpoint.routing_instance and object.peer_endpoint.routing_instance != '' %}
Copy link
Contributor

@mzbroch mzbroch May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the first check should be sufficient here.

Copy link
Author

@RaidAndFade RaidAndFade May 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not in my testing, since the model is defined and set as "" apparently?

Copy link
Contributor

@mzbroch mzbroch May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not in my testing, since the model is defined and set as "" apparently?

That points to instance of BGPRoutingInstance, so should be either instance of BGPRoutingInstance or None on PeerEndpoint model.

<td><a href="{% url 'plugins:nautobot_bgp_models:bgproutinginstance' pk=object.peer_endpoint.routing_instance.pk %}">{{ object.peer_endpoint.routing_instance }}</a></td>
{% else %}
<td><span class="text-muted">None</span></td>
{% endif %}
</tr>
<tr>
<td>Peer Endpoint</td>
Expand Down