Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DNA Center Location Structure #713

Merged
merged 4 commits into from
Feb 26, 2025

Conversation

jdrew82
Copy link
Contributor

@jdrew82 jdrew82 commented Feb 25, 2025

Closes: #687

What's Changed

This PR fixes the issue of top level locations not being created under Global like expected. This was determined to be due to the order of Areas being created. If the Global Area is to be imported it needs to be created first. This adds a custom diff class to ensure ordering of the Area locations to be created.

Screenshot 2025-02-25 at 11 36 58 AM
  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests

…p level first.

This should close #687 and ensure that Global and other top level Areas are created before lower level Areas.
@jdrew82 jdrew82 added type: bug Issues/PRs addressing a bug. integration: dna center Issues/PRs for Cisco DNA Center integration. labels Feb 25, 2025
@jdrew82 jdrew82 self-assigned this Feb 25, 2025
@jdrew82 jdrew82 requested a review from a team as a code owner February 25, 2025 18:07
@jdrew82 jdrew82 linked an issue Feb 25, 2025 that may be closed by this pull request
@jdrew82 jdrew82 force-pushed the patch-687-dna-center-location-structure-incorrect branch from 413b787 to 00719a6 Compare February 25, 2025 20:47
Copy link
Contributor

@bile0026 bile0026 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdrew82 jdrew82 merged commit 52a56af into develop Feb 26, 2025
15 checks passed
@jdrew82 jdrew82 deleted the patch-687-dna-center-location-structure-incorrect branch February 26, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration: dna center Issues/PRs for Cisco DNA Center integration. type: bug Issues/PRs addressing a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNA Center Location Structure Incorrect
2 participants