Kan endre fonttyper #1219
Open
Kan endre fonttyper #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Content & TextContent
Her jukser vi til endringen. Mulig vi må gjøre dette som ved literals
mulig bug med punktlister. Se om vi kan få punktliste PR inn i main først
…witchFontType actions
madsop-nav
reviewed
Jan 30, 2025
| }; | ||
|
|
||
| const switchFontTypeForVariable = (args: { | ||
| draft: Draft<LetterEditorState>; |
There was a problem hiding this comment.
draft, thisBlock og literalIndex er ikkje i bruk her, er det med vilje at dei er her lell?
madsop-nav
reviewed
Jan 30, 2025
|
|
||
| const text = args.literal.editedText ?? args.literal.text; | ||
|
|
||
| const isWhiteSpace = text[cursorPosition] === " "; |
There was a problem hiding this comment.
Er det ei reell problemstilling her med tabs, newline og andre måtar å lage whitespace på, eller skjer ikkje det her?
madsop-nav
reviewed
Jan 30, 2025
| const block = editorState.redigertBrev.blocks[editorState.focus.blockIndex]; | ||
| const theContentWeAreOn = block.content[editorState.focus.contentIndex]; | ||
|
|
||
| // console.log("the block:", block); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cypress bestemte seg for at noen imports ikke var greie nok. Så måtte fikse noen der 🤷
Merk at implementasjon av å endre fonttype på variabler er lagt inn, uten backend støtte. Kanskje vi skal fjerne dette?