Skip to content

Commit

Permalink
IS-2729: Remove toggle for hendelse column (#529)
Browse files Browse the repository at this point in the history
  • Loading branch information
vetlesolgaard authored Oct 16, 2024
1 parent 6348c5d commit 852d4c8
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 27 deletions.
10 changes: 3 additions & 7 deletions server/unleash.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import unleashClient = require('unleash-client');
import { Strategy } from 'unleash-client';
import Config = require('./config');
import { Strategy } from 'unleash-client';
import { Context } from 'unleash-client/lib/context';

const { initialize } = unleashClient;
Expand Down Expand Up @@ -32,7 +32,7 @@ export const unleash = initialize({
strategies: [new VeilederIds(), new EnhetIds()],
});

export const getToggles = (veilederId: any, enhetId: any) => {
export function getToggles(veilederId: any, enhetId: any) {
const context = {
veilederId: veilederId,
enhetId: enhetId,
Expand All @@ -44,13 +44,9 @@ export const getToggles = (veilederId: any, enhetId: any) => {
'isOppfolgingISenFaseEnabled',
context
),
isHendelseColumnEnabled: unleash.isEnabled(
'isHendelseColumnEnabled',
context
),
isManglendeMedvirkningEnabled: unleash.isEnabled(
'isManglendeMedvirkningEnabled',
context
),
};
};
}
30 changes: 12 additions & 18 deletions src/components/NewOversiktTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { Sorting, SortingKey, useSorting } from '@/hooks/useSorting';
import { LinkSyfomodiaperson } from '@/components/LinkSyfomodiaperson';
import { toLastnameFirstnameFormat } from '@/utils/stringUtil';
import { getHendelser } from '@/utils/statusColumnUtils';
import { useFeatureToggles } from '@/data/unleash/unleashQueryHooks';
import { useTabType } from '@/context/tab/TabTypeContext';
import { OverviewTabType } from '@/konstanter';

Expand Down Expand Up @@ -37,7 +36,6 @@ export const NewOversiktTable = ({
setSorting,
}: Props): ReactElement => {
const { columns } = useSorting();
const { toggles } = useFeatureToggles();
const { tabType } = useTabType();

const handleSort = (sortKey: string | undefined) => {
Expand Down Expand Up @@ -99,10 +97,8 @@ export const NewOversiktTable = ({
{columns
.filter(
(column) =>
(toggles.isHendelseColumnEnabled ||
column.sortKey !== 'HENDELSE') &&
(tabType === OverviewTabType.ENHET_OVERVIEW ||
column.sortKey !== 'VEILEDER')
tabType === OverviewTabType.ENHET_OVERVIEW ||
column.sortKey !== 'VEILEDER'
)
.map((col, index) => (
<Table.ColumnHeader key={index} sortKey={col.sortKey} sortable>
Expand Down Expand Up @@ -161,18 +157,16 @@ export const NewOversiktTable = ({
<Table.DataCell textSize="small">
<FristColumn personData={persondata} />
</Table.DataCell>
{toggles.isHendelseColumnEnabled && (
<Table.DataCell
textSize="small"
className="[&>*:not(:last-child)]:mb-1.5"
>
{getHendelser(persondata).map((status, index) => (
<p key={index} className="m-0">
{status}
</p>
))}
</Table.DataCell>
)}
<Table.DataCell
textSize="small"
className="[&>*:not(:last-child)]:mb-1.5"
>
{getHendelser(persondata).map((status, index) => (
<p key={index} className="m-0">
{status}
</p>
))}
</Table.DataCell>
</Table.Row>
))}
</Table.Body>
Expand Down
2 changes: 0 additions & 2 deletions src/data/unleash/types/unleash_types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,12 @@ export enum ToggleNames {
isFlexjarArenaEnabled = 'isFlexjarArenaEnabled',
isFrisktilarbeidEnabled = 'isFrisktilarbeidEnabled',
isOppfolgingISenFaseEnabled = 'isOppfolgingISenFaseEnabled',
isHendelseColumnEnabled = 'isHendelseColumnEnabled',
isManglendeMedvirkningEnabled = 'isManglendeMedvirkningEnabled',
}

export const defaultToggles: Toggles = {
isFlexjarArenaEnabled: false,
isFrisktilarbeidEnabled: false,
isOppfolgingISenFaseEnabled: false,
isHendelseColumnEnabled: false,
isManglendeMedvirkningEnabled: false,
};

0 comments on commit 852d4c8

Please sign in to comment.