Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tilgangskontroll siste 14a vedtak #662

Closed
wants to merge 3 commits into from

Conversation

slovrid
Copy link
Contributor

@slovrid slovrid commented Feb 3, 2025

Denne PR-en gjer i hovedsak to ting:

  • Introduserer tilgangType-parameter slik at vi skal kunne skilje på kva type tilgangskontroll (SKRIVE eller LESE) vi ønskjer å bruke for dei ulike endepunkta våra
    • Eg setter default-argument til å vere SKRIVE - dette var mest for å sleppe å sende inn det nye argumentet overalt kor det skal vere uendra - eg endte likevel opp med å måtte bruke name-arguments ved callsite for at kompilatoren skulle verte glad, så vi kan vurdere å ikkje bruke default-argument for tilgangType og heller spesifisere dette overalt
  • Endra på tilgangskontroll i /hent-siste-14a-vedtak-endepunktet frå å kreve SKRIVE-tilgang til å no berre kreve LESE-tilgang, då vi meinar det er ein bug/feil at vi har krev SKRIVE-tilgang

@slovrid slovrid requested a review from a team as a code owner February 3, 2025 13:56
@github-actions github-actions bot added the not dependabot PRs opened by humans (and other bots) label Feb 3, 2025
Copy link

sonarqubecloud bot commented Feb 3, 2025

@slovrid slovrid closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not dependabot PRs opened by humans (and other bots)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant