Skip to content

PFDA - G4SSM updates#675

Merged
iaromoskviak merged 123 commits intodevelopment_3.0from
pfda_g4_pr
Apr 20, 2026
Merged

PFDA - G4SSM updates#675
iaromoskviak merged 123 commits intodevelopment_3.0from
pfda_g4_pr

Conversation

@ihitch
Copy link
Copy Markdown
Collaborator

@ihitch ihitch commented Mar 24, 2026

  • generate .svg for step view (remove scheme view)
  • Add "Add Draft" button to G4 and enable referencing drafts in the form
  • Add bulk submission of draft substances
  • Add Save Local Batch to G4 to download the G4 json + draft jsons referenced
  • Change behavior of saving chemical drafts - generate uuid directly upon saving.

Please review our changes carefully; we had to resolve a ton of merge conflicts with the latest development_3.0 branch, so hopefully it didn't break anything on your end. We tested it on our instance, and it works as expected.

@ihitch ihitch marked this pull request as ready for review April 1, 2026 13:35
@ihitch ihitch requested review from ChemMitch and iaromoskviak April 1, 2026 13:50
Copy link
Copy Markdown
Collaborator

@iaromoskviak iaromoskviak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • In substance-drafts.component.ts (submit flow), the loading state is being turned off inside each individual request. So if you submit multiple drafts, the spinner can disappear after the first one finishes even though others are still running. This can make it look like everything completed when it hasn’t. I think this should wait until all submissions finish (e.g., forkJoin or a completion counter).

  • Since this PR was opened before 676/677 were merged, I think you should rebase or merge latest development_3.0 into this branch and do one more test pass. Given how many core files this touches, there’s a real risk that conflict resolution may have unintentionally overridden newer behavior.

Comment thread src/app/core/substance-form/substance-drafts/substance-drafts.component.ts Outdated
@ihitch
Copy link
Copy Markdown
Collaborator Author

ihitch commented Apr 15, 2026

@iaromoskviak Thanks for the feedback. I've updated the drafts submit flow to ensure the loading spinner stays active until all submissions are complete.

As for testing against the latest development_3.0 changes, we actually had QA test build 3.2.0 with this exact frontend branch (pfda_g4_pr). All of our regression tests passed and QA gave us the green light, so everything is working fine and no further testing should be needed.

@ihitch ihitch requested a review from iaromoskviak April 20, 2026 14:05
@iaromoskviak iaromoskviak merged commit 8021247 into development_3.0 Apr 20, 2026
2 of 6 checks passed
@iaromoskviak iaromoskviak deleted the pfda_g4_pr branch April 20, 2026 16:48
@ihitch ihitch restored the pfda_g4_pr branch April 27, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants