PFDA - G4SSM updates#675
Conversation
Resolve 21 merge conflicts, keeping pfda_g4_pr draft features (batch validation/submission, draft selector, structure interpretation) while adopting development_3.0 updates (jsonpath over defiant, standalone:false, cleaner formatting, additional validations).
iaromoskviak
left a comment
There was a problem hiding this comment.
-
In
substance-drafts.component.ts(submit flow), the loading state is being turned off inside each individual request. So if you submit multiple drafts, the spinner can disappear after the first one finishes even though others are still running. This can make it look like everything completed when it hasn’t. I think this should wait until all submissions finish (e.g.,forkJoinor a completion counter). -
Since this PR was opened before 676/677 were merged, I think you should rebase or merge latest
development_3.0into this branch and do one more test pass. Given how many core files this touches, there’s a real risk that conflict resolution may have unintentionally overridden newer behavior.
|
@iaromoskviak Thanks for the feedback. I've updated the drafts submit flow to ensure the loading spinner stays active until all submissions are complete. As for testing against the latest |
.svgfor step view (remove scheme view)Save Local Batchto G4 to download the G4 json + draft jsons referencedPlease review our changes carefully; we had to resolve a ton of merge conflicts with the latest
development_3.0branch, so hopefully it didn't break anything on your end. We tested it on our instance, and it works as expected.