Skip to content

Conversation

@preston-evans98
Copy link
Contributor

No description provided.

@preston-evans98 preston-evans98 requested a review from frol as a code owner February 3, 2023 19:44
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@preston-evans98 Overall, it looks good to me. Could you also add tests and a record to the CHANGELOG file in the root of the project?

@preston-evans98
Copy link
Contributor Author

@preston-evans98 Overall, it looks good to me. Could you also add tests and a record to the CHANGELOG file in the root of the project?

Sure thing! Clippy is failing for reasons that look (at a glance) unrelated to this change. Have you encountered those before? If not, I can dig in and debug.

@preston-evans98 preston-evans98 changed the title Implement serialize/deserialize fore core::ops::Range Implement serialize/deserialize for core::ops::Range Feb 6, 2023
@preston-evans98
Copy link
Contributor Author

It turned out the clippy issue was just some new lints added since the last pull. I've fixed the warnings and rebased on top.

In case you prefer to keep the PRs separate, I've opened #125. Feel free to close without comment if you'd prefer to merge both changes together.

@preston-evans98 preston-evans98 requested a review from frol February 7, 2023 00:10
@frol frol merged commit 68c11a6 into near:master Feb 8, 2023
@frol
Copy link
Collaborator

frol commented Feb 8, 2023

@preston-evans98 Thanks for the contribution! 🎉

@frol
Copy link
Collaborator

frol commented Feb 8, 2023

@preston-evans98 borsh 0.10.1 has just been released with this change included!

@preston-evans98
Copy link
Contributor Author

Amazing, thanks!

This was referenced May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants