feat: improve configuration as suggested by publint #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No linked issues found. Please add the corresponding issues in the pull request description. |
simoneb
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the warnings reported by publint.
As per the recommendation to fix the warnings, we have to make sure that the type declarations live adjacent to the resolved JS file. So I have removed tsconfig which generates the types separately and I am now generating types for both CommonJS and ESM modules. I also noticed during my testing that exposing the type declarations this way makes sure that the IDEs pick the types out-of-the-box which was not happening prior to this PR.
I also came across this documentation which says
pkg.mainis not needed when we havepkg.exportsdefined. So I have got rid of the not needed fields as well.