chore(ci): fix failing build when deploying #742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No linked issues found. Please add the corresponding issues in the pull request description. |
Pupix
changed the title
simoneb
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Thanks for catching this and the research that you put into it. What do you think is a reasonable long term solution here?
Let's think outside the box, we are not necessarily tied to slidev either, although it's used across all our repos so ideally we stay consistent, one way or another.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just noticed that the deploy workflow is failing. History here
There seems to have been an update to slidev 2 months ago that most likely broke it, since the last deploy we can see is 3 months ago.
The main issue is npm/cli#4828 and these are some related ones vitejs/vite#15532 and IgniteUI/grid-demos#14, both of which suggest to apply the patch of this PR.
The OWASP repo for example is still on an older version and the deploy works as expected. Last deploy was 1 hour ago. My guess is that too will break as soon as slidev is updated and the lines related to it in package-lock.json will change.