feat: allow extensions of LaconiaContext and Error types #814
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LaconiaContext
andError
typesExtending Error
Extending LaconiaContext
So my motivation for this one is because
LaconiaContext
is pretty loosely typed with[key: string]: any;
, I wanted a way to extend it to improve upon the typing. We might even eventually removing that type ([key: string]: any;
), but that would be a definite breaking change that would need more consideration.Other comments
This is the typescript playgroud that I was using to test the types