Add support for accessing network shares #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
|
The first 2 commits could be merged straight away though. |
Don't rely on backends providing more information than we requested. If we don't ask for the file type, some gvfs backend won't provide it.
hadess
force-pushed
the
wip/hadess/remote-support
branch
from
608f6d7 to
ca47c21
Compare
|
I've rebased the code, still has the same problems, the first 2 commits could still be merged ;) One thing I've also noticed is that "Move to Trash" won't work on some remote filesystems, and that the code should check for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works, but the speed is pretty atrocious. I don't know what calls it's doing in the background, but it seems to have problems redrawing fast enough to keep the UI responsive.