Repository navigation
[fix] Linking: register listeners once and remove by subscription - #2919
Merged
Merged
Conversation
|
Size Change: -187 B (-0.14%) Total Size: 134 kB 📦 View Changed
|
Kudo
approved these changes
Oct 20, 2026
Kudo
left a comment
Kudo
left a comment
Collaborator
There was a problem hiding this comment.
leaving some agent review comments. leave you to judge if that's reasonable
Collaborator
Author
|
@Kudo Thanks, I fixed them all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #2901.
The first
Linking.addEventListenercall added its callback twice.remove()comparedtoString(), so it also removed other callbacks with the same source.Each subscription now stores its own entry in a
Set, andremove()deletes only that entry. Callingremove()again does nothing. If the same function is registered twice, removing one subscription keeps the other.Other changes:
addListener,emit,listenerCount,removeAllListeners,sendIntentandopenSettingsto match the React Native 0.88 API.removeEventListener. React Native 0.88 does not have it._validateURL.