Repository navigation
[fix] Pressable: call onPress on Enter when role is "link" - #2926
Open
Enesuygurs wants to merge 1 commit into
Open
Enesuygurs wants to merge 1 commit into
Enesuygurs wants to merge 1 commit into
Conversation
An ARIA "link" role does not make an element dispatch a native 'click' on Enter, so PressResponder must call onPress itself unless the element is an actual anchor. Fix necolas#2681
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2681.
<Pressable role="link" onPress={...} />renders adivwithrole="link". Pressing Enter on it firesonPressIn/onPressOut, but neveronPress.The keyup handler in
PressResponderskipsonPressfor native interactive elements, because the browser dispatches aclickfor them. That list also includedrole === 'link', but an ARIA role does not give adivthat native behavior, soonPresswas never called. A real anchor (Pressablewithhref) is still covered by theaelement check, so it doesn't fire twice.Test plan
Pressablewithrole="link"callsonPressonce on Enter (fails before the fix)Pressablewithrole="link"andhrefrenders an<a>and leaves activation to the nativeclicknpm run unit: 48 suites, 703 passed, 6 skippednpm run lint,prettier --check