Skip to content

Fix PHPDoc blocks #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

szepeviktor
Copy link

@szepeviktor szepeviktor commented Nov 21, 2020

This packages needs a lot of loving care.

Please consider declaring types of everything and using FQCN-s in PHPDoc-s and for exceptions.

@szepeviktor
Copy link
Author

Static analysis

phpstan.neon.dist

includes:
    - vendor/nunomaduro/larastan/extension.neon
parameters:
    level: 2
#    level: 5
#    level: max
    paths:
        - src/
        - config/
        - database/
        - resources/
    ignoreErrors:
        # TODO Consider making static things final.
        - '#^Unsafe usage of new static#'
composer require --dev nunomaduro/larastan orchestra/testbench
cp -a database/migrations/* vendor/orchestra/testbench-core/laravel/database/migrations/
vendor/bin/phpstan analyze

All the best to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant