Skip to content

NEP11/17 contract validator #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 52 commits into from
Nov 26, 2023
Merged

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Nov 9, 2023

closes #194

Sorry closed PR by accident #311

image

Also validates the manifest on deploy for NEP-11 or NEP-17. Checks the SupportedStandards

@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Nov 9, 2023

I need neo-blockchaintoolkit-library in this repo to complete this PR, i have to add some methods to RPC server its a custom plugin for neo-express. No one there to merge changes or anything.

@cschuchardt88
Copy link
Member Author

Waiting to see what happens with neo-project/neo-devpack-dotnet#812

@roman-khimov
Copy link

Notice that tokens and properties are optional, contract can omit them. And IIUC runtime checks for divisible NFT methods are not implemented yet.

It'd also be nice to add checks for onNEPXXPayment methods.

NeoGo compiler provides manifest checks by default (requires --no-standards to disable them), but it doesn't try running the contract. Internally it's implemented in this package if you're interested: https://pkg.go.dev/github.com/nspcc-dev/[email protected]/pkg/smartcontract/manifest/standard

@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Nov 11, 2023

@Ashuaidehao How you run neo-express in Online mode?

@cschuchardt88 cschuchardt88 marked this pull request as ready for review November 18, 2023 04:26
@cschuchardt88
Copy link
Member Author

This is an ok start for now.

@Jim8y Jim8y merged commit 22276dd into neo-project:master Nov 26, 2023
@cschuchardt88 cschuchardt88 deleted the issue-194 branch November 26, 2023 06:05
@cschuchardt88 cschuchardt88 mentioned this pull request Dec 3, 2023
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NEP11/17 contract validator
4 participants