Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend manifest v1 style handshake tests #652

Merged
merged 6 commits into from
Feb 13, 2025
Merged

Extend manifest v1 style handshake tests #652

merged 6 commits into from
Feb 13, 2025
+68 −5

Conversation

robsdedude
Copy link
Contributor

No description provided.

@robsdedude robsdedude mentioned this pull request Feb 11, 2025
Merged
MaxAake
MaxAake reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@MaxAake MaxAake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬

tests/stub/transport/test_handshakes.py Outdated Show resolved Hide resolved
tests/stub/transport/test_handshakes.py Outdated Show resolved Hide resolved
@robsdedude robsdedude requested a review from MaxAake February 13, 2025 10:10
MaxAake
MaxAake reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@MaxAake MaxAake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬

tests/stub/transport/test_handshakes.py Outdated Show resolved Hide resolved
@robsdedude robsdedude requested a review from MaxAake February 13, 2025 11:24
MaxAake
MaxAake approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@MaxAake MaxAake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@robsdedude robsdedude enabled auto-merge (squash) February 13, 2025 12:15
@robsdedude robsdedude merged commit 1b3ae4c into 5.0 Feb 13, 2025
8 checks passed
@robsdedude robsdedude deleted the extend-handshake-manifest-tests branch February 13, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxAake MaxAake MaxAake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robsdedude @MaxAake