Add ruby error assertion for test_rejects_uuid_result - #725
Open
klobuczek wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds the missing Ruby-specific error assertion in test_rejects_uuid_result so the Ruby driver no longer falls into the NotImplementedError branch when receiving a UUID PackStream marker (0xE0) over Bolt 6.0.
Changes:
- Extend the Java error-assertion branch to also cover the Ruby driver.
- Assert Ruby error message contains
"unknown packstream"and"e0"(matching the Java/JRuby-wrapped behavior described in the PR).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_rejects_uuid_result(UUID over Bolt 6.0) branches ondriver_namefor the expected error, but has norubycase, so the Ruby driver hitsraise NotImplementedError(f"Add error assertion for {driver_name}").The Ruby driver's JRuby implementation wraps the official Java driver, so a UUID PackStream marker (
0xE0) received over Bolt 6.0 surfaces the same error as the Java driver. This adds"ruby"alongside"java", asserting"unknown packstream"and"e0".All other UUID tests (
test_uuid,test_uuid_as_node_property,test_uuid_in_list,test_uuid_in_map,test_rejects_uuid_parameter) already pass for the Ruby driver unchanged.