Skip building the Rust boltstub when TEST_RUSTY_STUB isn't set - #728
Merged
Conversation
The runner image unconditionally installed the Rust toolchain and ran cargo build --release regardless of which stub server the run actually uses, wasting disk and time on every non-rusty-stub job. This is the root cause behind several disk-space CI failures on this PR: jobs that never touch the Rust stub were still paying its full build cost. BUILD_RUST_STUB defaults to true (safe for a manual docker build with no extra args); runner.py now derives it from TEST_RUSTY_STUB using the same truthy check already used in tests/stub/shared.py. Verified locally: both branches build cleanly, the real path still produces a working boltstub binary, the skipped path installs no Rust toolchain at all.
Contributor
Author
|
I'm self-merging this since it is a cause of flaky builds across the team. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runner image unconditionally installed the Rust toolchain and ran
cargo build --releaseregardless of which stub server the run actually uses, using disk and time on every non-rusty-stub job. This was traced back as the root cause of several disk-space CI failures: non-rusty-stub builds only requested 3gb of space, but the toolchain install,apt-getpackages, and the compile itself happened every time.Verified on PR #727's full CI run: the javascript composite, which had failed four times in a row on disk exhaustion, passed cleanly once this fix was in place, and all 14 checks on that PR went green.