Fix flaky tests #827
Open
Fix flaky tests #827
+119
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvub
approved these changes
Aug 20, 2025
| @@ -392,12 +398,12 @@ public void testRelationshipExists() { | |||
| db.executeTransactionally("CREATE INDEX rel_index_composite FOR ()-[r:PURCHASED]-() ON (r.date, r.amount)"); | |||
| awaitIndexesOnline(); | |||
|
|
|||
| assertTrue(singleResultFirstColumn(db, "RETURN apoc.schema.relationship.indexExists('KNOWS', ['since'])")); | |||
There was a problem hiding this comment.
Why is this assertion removed? It feels like is should still be true, doesn't it?
There was a problem hiding this comment.
Oops, that's a mistake, thanks.
Comment on lines
-848
to
+856
| "name='index3', type='TEXT', schema=(:Person {name}), indexProvider='text-2.0' )"); | ||
| "name='index3', type='TEXT', schema=(:Person {name}), indexProvider='text-3.0' )"); |
There was a problem hiding this comment.
Not sure it is make sense to assert on a specific index provider.
There was a problem hiding this comment.
Agree, but I'll leave that for the next time :).
loveleif
force-pushed
the
fix-scehma-flaky
branch
from
3cb7e8f to
3cb80c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.